Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1397)

Unified Diff: content/browser/screen_orientation/screen_orientation.h

Issue 2630323002: [ScreenOrientation] Fix a possible crash point in ScreenOrientationProvider. (Closed)
Patch Set: ScreenOrientation does not maintain pending lock request Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/screen_orientation/screen_orientation.h
diff --git a/content/browser/screen_orientation/screen_orientation.h b/content/browser/screen_orientation/screen_orientation.h
index 677a4c3cfea92374cbcc3754ac4c354ad00bcbe5..68a16158a1abbff5dbddde183836a853f3c9cf88 100644
--- a/content/browser/screen_orientation/screen_orientation.h
+++ b/content/browser/screen_orientation/screen_orientation.h
@@ -5,7 +5,6 @@
#ifndef CONTENT_BROWSER_SCREEN_ORIENTATION_SCREEN_ORIENTATION_H
#define CONTENT_BROWSER_SCREEN_ORIENTATION_SCREEN_ORIENTATION_H
-#include "base/callback.h"
#include "base/memory/weak_ptr.h"
#include "content/public/browser/web_contents_binding_set.h"
#include "content/public/browser/web_contents_observer.h"
@@ -34,10 +33,7 @@ class ScreenOrientation : public device::mojom::ScreenOrientation,
void DidNavigateMainFrame(const LoadCommittedDetails& details,
const FrameNavigateParams& params) override;
- void NotifyLockResult(device::mojom::ScreenOrientationLockResult result);
-
std::unique_ptr<ScreenOrientationProvider> provider_;
- LockOrientationCallback on_result_callback_;
WebContentsFrameBindingSet<device::mojom::ScreenOrientation> bindings_;
base::WeakPtrFactory<ScreenOrientation> weak_factory_;
};

Powered by Google App Engine
This is Rietveld 408576698