ios/chrome/browser/ui/suggestions/suggestions_stack_item_actions.h - Issue 2630313004: Suggestions UI - stack item

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/chrome/browser/ui/suggestions/suggestions_stack_item_actions.h

Issue 2630313004: Suggestions UI - stack item (Closed)

Patch Set: Cleanup Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef IOS_CHROME_BROWSER_UI_SUGGESTIONS_SUGGESTIONS_STACK_ITEM_ACTIONS_H_

	6 #define IOS_CHROME_BROWSER_UI_SUGGESTIONS_SUGGESTIONS_STACK_ITEM_ACTIONS_H_

	7

	8 // Actions for the Suggestions Stack.

	9 @protocol SuggestionsStackItemActions

	10

	11 // The item on the top of the stack have been pressed.

	12 - (void)topOfStackPressed:(id)sender;
	marq (ping after 24h) 2017/01/16 18:04:42 That's not an action, that's an event. The intent That's not an action, that's an event. The intent of an action protocol is to give a name (a selector) to an action like 'close tab' or 'add to list' so that the action can be set as the target for a control. What should happen when the top of the stack is pressed? gambard 2017/01/17 13:28:11 Done. Show quoted text On 2017/01/16 18:04:42, marq wrote: > That's not an action, that's an event. The intent of an action protocol is to > give a name (a selector) to an action like 'close tab' or 'add to list' so that > the action can be set as the target for a control. What should happen when the > top of the stack is pressed? Done.
	13

	14 @end

	15

	16 #endif // IOS_CHROME_BROWSER_UI_SUGGESTIONS_SUGGESTIONS_STACK_ITEM_ACTIONS_H_

OLD	NEW