Suggestions UI - stack item

ios/chrome/browser/ui/suggestions/suggestions_stack_item.mm

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#import "ios/chrome/browser/ui/suggestions/suggestions_stack_item.h"
+
+#import "ios/chrome/browser/ui/suggestions/suggestions_stack_item_actions.h"
+#import "ios/chrome/browser/ui/uikit_ui_util.h"
+
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
+namespace {
+const NSInteger kStackSpacing = 8;

[marq (ping after 24h), 2017/01/16 18:04:42]

If this is used to positions views, it should be a CGFloat.

[gambard, 2017/01/17 13:28:11]

Done.

+}
+
+@implementation SuggestionsStackItem {
+  NSString* _title;
+  NSString* _subtitle;
+}
+
+- (instancetype)initWithType:(NSInteger)type
+                       title:(NSString*)title
+                    subtitle:(NSString*)subtitle {
+  self = [super initWithType:type];
+  if (self) {
+    self.cellClass = [SuggestionsStackCell class];
+    _title = [title copy];
+    _subtitle = [subtitle copy];
+  }
+  return self;
+}
+
+#pragma mark - CollectionViewItem
+
+- (void)configureCell:(SuggestionsStackCell*)cell {
+  [super configureCell:cell];
+  [cell.titleButton setTitle:_title forState:UIControlStateNormal];
+  cell.detailTextLabel.text = _subtitle;
+}
+
+@end
+
+@implementation SuggestionsStackCell
+
+@synthesize titleButton = _titleButton;
+@synthesize detailTextLabel = _detailTextLabel;
+
+- (instancetype)initWithFrame:(CGRect)frame {
+  self = [super initWithFrame:frame];
+  if (self) {
+    self.backgroundColor = [UIColor clearColor];
+    self.contentView.backgroundColor = [UIColor clearColor];
+    self.backgroundView.backgroundColor = [UIColor clearColor];
+
+    UIControl* itemDisplay = [[UIControl alloc] init];
+    itemDisplay.layer.borderColor = [UIColor blackColor].CGColor;
+    itemDisplay.layer.borderWidth = 1;
+    itemDisplay.backgroundColor = [UIColor whiteColor];
+    [itemDisplay addTarget:nil
+                    action:@selector(topOfStackPressed:)
+          forControlEvents:UIControlEventTouchUpInside];
+    itemDisplay.translatesAutoresizingMaskIntoConstraints = NO;
+
+    _titleButton = [UIButton buttonWithType:UIButtonTypeSystem];
+    _detailTextLabel = [[UILabel alloc] init];
+    _titleButton.translatesAutoresizingMaskIntoConstraints = NO;
+    _detailTextLabel.translatesAutoresizingMaskIntoConstraints = NO;
+
+    [itemDisplay addSubview:_titleButton];
+    [itemDisplay addSubview:_detailTextLabel];
+
+    UIView* secondView = [[UIView alloc] init];

[marq (ping after 24h), 2017/01/16 18:04:42]

If these are placeholders, please add comments indicating as much.

[gambard, 2017/01/17 13:28:11]

Done.

+    secondView.backgroundColor = [UIColor whiteColor];
+    secondView.translatesAutoresizingMaskIntoConstraints = NO;
+    secondView.layer.borderColor = [UIColor blackColor].CGColor;
+    secondView.layer.borderWidth = 1;
+
+    UIView* thirdView = [[UIView alloc] init];
+    thirdView.backgroundColor = [UIColor whiteColor];
+    thirdView.translatesAutoresizingMaskIntoConstraints = NO;
+    thirdView.layer.borderColor = [UIColor blackColor].CGColor;
+    thirdView.layer.borderWidth = 1;
+
+    UIView* fourthView = [[UIView alloc] init];
+    fourthView.backgroundColor = [UIColor whiteColor];
+    fourthView.translatesAutoresizingMaskIntoConstraints = NO;
+    fourthView.layer.borderColor = [UIColor blackColor].CGColor;
+    fourthView.layer.borderWidth = 1;
+
+    [self.contentView addSubview:itemDisplay];

[marq (ping after 24h), 2017/01/16 18:04:42]

Why not just reverse the order of these and use -addSubview: in each case?

[gambard, 2017/01/17 13:28:11]

This shows there is an intended order. Using only -addSubview: let the reader
wonder if it is on purpose.

+    [self.contentView insertSubview:secondView belowSubview:itemDisplay];
+    [self.contentView insertSubview:thirdView belowSubview:secondView];
+    [self.contentView insertSubview:fourthView belowSubview:thirdView];
+
+    [NSLayoutConstraint activateConstraints:@[
+      [itemDisplay.widthAnchor constraintEqualToAnchor:secondView.widthAnchor],
+      [itemDisplay.heightAnchor
+          constraintEqualToAnchor:secondView.heightAnchor],
+      [itemDisplay.widthAnchor constraintEqualToAnchor:thirdView.widthAnchor],
+      [itemDisplay.heightAnchor constraintEqualToAnchor:thirdView.heightAnchor],
+      [itemDisplay.widthAnchor constraintEqualToAnchor:fourthView.widthAnchor],
+      [itemDisplay.heightAnchor
+          constraintEqualToAnchor:fourthView.heightAnchor],
+    ]];
+
+    ApplyVisualConstraintsWithMetrics(
+        @[
+          @"H:|-[title]-|",
+          @"H:|-[text]-|",
+          @"H:|[item]-(fourSpace)-|",
+          @"H:|-(oneSpace)-[second]-(threeSpace)-|",
+          @"H:|-(twoSpace)-[third]-(twoSpace)-|",
+          @"H:|-(threeSpace)-[fourth]-(oneSpace)-|",
+          @"V:|-[title]-[text]-|",
+          @"V:|[item]",
+          @"V:|-(oneSpace)-[second]",
+          @"V:|-(twoSpace)-[third]",
+          @"V:|-(threeSpace)-[fourth]|",
+        ],
+        @{
+          @"title" : _titleButton,
+          @"text" : _detailTextLabel,
+          @"item" : itemDisplay,
+          @"second" : secondView,
+          @"third" : thirdView,
+          @"fourth" : fourthView,
+        },
+        @{
+          @"oneSpace" : @(kStackSpacing * 1),
+          @"twoSpace" : @(kStackSpacing * 2),
+          @"threeSpace" : @(kStackSpacing * 3),
+          @"fourSpace" : @(kStackSpacing * 4)
+        });
+  }
+  return self;
+}
+
+@end