ios/chrome/browser/ui/suggestions/suggestions_stack_item.h - Issue 2630313004: Suggestions UI - stack item

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/chrome/browser/ui/suggestions/suggestions_stack_item.h

Issue 2630313004: Suggestions UI - stack item (Closed)

Patch Set: Cleanup Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ios/chrome/browser/ui/suggestions/BUILD.gn ('K') | « ios/chrome/browser/ui/suggestions/suggestions_item_unittest.mm ('k') | ios/chrome/browser/ui/suggestions/suggestions_stack_item.mm » ('j') | ios/chrome/browser/ui/suggestions/suggestions_stack_item.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef IOS_CHROME_BROWSER_UI_SUGGESTIONS_SUGGESTIONS_STACK_ITEM_H_

	6 #define IOS_CHROME_BROWSER_UI_SUGGESTIONS_SUGGESTIONS_STACK_ITEM_H_

	7

	8 #import "ios/chrome/browser/ui/collection_view/cells/collection_view_item.h"

	9 #import "ios/third_party/material_components_ios/src/components/CollectionCells/ src/MaterialCollectionCells.h"

	10

	11 // Item for a suggestions item with a title and subtitle.
	marq (ping after 24h) 2017/01/16 18:04:42 Describe what a StackItem is. Describe what a StackItem is. gambard 2017/01/17 13:28:11 Done. Show quoted text On 2017/01/16 18:04:42, marq wrote: > Describe what a StackItem is. Done.
	12 @interface SuggestionsStackItem : CollectionViewItem

	13

	14 // Init a suggestions item with a \|title\| and a \|subtitle\|. \|type\| is the type
	marq (ping after 24h) 2017/01/16 18:04:42 Initialize. Initialize. gambard 2017/01/17 13:28:11 Done. Show quoted text On 2017/01/16 18:04:42, marq wrote: > Initialize. Done.
	15 // of the item.

	16 - (instancetype)initWithType:(NSInteger)type

	17 title:(NSString*)title

	18 subtitle:(NSString*)subtitle NS_DESIGNATED_INITIALIZER;

	19 - (instancetype)initWithType:(NSInteger)type NS_UNAVAILABLE;

	20

	21 @end

	22

	23 // Corresponding cell for a suggestion item.
	marq (ping after 24h) 2017/01/16 18:04:42 s/suggestion item/suggestion stack item/ s/suggestion item/suggestion stack item/ gambard 2017/01/17 13:28:11 Done. Show quoted text On 2017/01/16 18:04:42, marq wrote: > s/suggestion item/suggestion stack item/ Done.
	24 @interface SuggestionsStackCell : MDCCollectionViewCell

	25

	26 @property(nonatomic, readonly, strong) UIButton* titleButton;
	marq (ping after 24h) 2017/01/16 18:04:42 Do these need to be public properties? Do these need to be public properties? gambard 2017/01/17 13:28:11 They are used by the item to set the title and the Show quoted text On 2017/01/16 18:04:42, marq wrote: > Do these need to be public properties? They are used by the item to set the title and the subtitle.
	27 @property(nonatomic, readonly, strong) UILabel* detailTextLabel;

	28

	29 @end

	30

	31 #endif // IOS_CHROME_BROWSER_UI_SUGGESTIONS_SUGGESTIONS_STACK_ITEM_H_

OLD	NEW