content/browser/service_worker/service_worker_write_to_cache_job.cc - Issue 2630273002: ServiceWorker: mojofy ResumeAfterDownload and AddMessageToConsole

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_write_to_cache_job.cc

Issue 2630273002: ServiceWorker: mojofy ResumeAfterDownload and AddMessageToConsole (Closed)

Patch Set: Added a comment Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/embedded_worker_test_helper.cc ('K') | « content/browser/service_worker/service_worker_version.cc ('k') | content/common/service_worker/embedded_worker.mojom » ('j') | third_party/WebKit/public/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_write_to_cache_job.cc

diff --git a/content/browser/service_worker/service_worker_write_to_cache_job.cc b/content/browser/service_worker/service_worker_write_to_cache_job.cc

index 1deab98e77afff2b07d9befcc4a432f8ed05ecb2..6edaf19a563fc98527cdb77e60b0656115ac72d3 100644

--- a/content/browser/service_worker/service_worker_write_to_cache_job.cc

+++ b/content/browser/service_worker/service_worker_write_to_cache_job.cc

@@ -26,6 +26,7 @@

#include "net/url_request/url_request.h"

#include "net/url_request/url_request_context.h"

#include "net/url_request/url_request_status.h"

+#include "third_party/WebKit/public/web/WebConsoleMessage.h"

namespace content {

@@ -437,7 +438,7 @@ net::Error ServiceWorkerWriteToCacheJob::NotifyFinishedCaching(

// occurred because the worker stops soon after receiving the error

// response.

version_->embedded_worker()->AddMessageToConsole(

- CONSOLE_MESSAGE_LEVEL_ERROR,

+ blink::WebConsoleMessage::LevelError,

status_message.empty() ? kFetchScriptError : status_message);

} else {

size = cache_writer_->bytes_written();