Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Unified Diff: content/browser/service_worker/embedded_worker_instance.cc

Issue 2630273002: ServiceWorker: mojofy ResumeAfterDownload and AddMessageToConsole (Closed)
Patch Set: s/is/was/ , add :: before blink and remove unnecessary include Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/embedded_worker_instance.cc
diff --git a/content/browser/service_worker/embedded_worker_instance.cc b/content/browser/service_worker/embedded_worker_instance.cc
index 3de092bcff17d23842c28e7b6fa865a6dc0b5fac..5bee584a60c9f391479dce2c425206f6e7f175b4 100644
--- a/content/browser/service_worker/embedded_worker_instance.cc
+++ b/content/browser/service_worker/embedded_worker_instance.cc
@@ -28,6 +28,7 @@
#include "content/public/common/child_process_host.h"
#include "content/public/common/content_switches.h"
#include "ipc/ipc_message.h"
+#include "third_party/WebKit/public/web/WebConsoleMessage.h"
#include "url/gurl.h"
namespace content {
@@ -514,7 +515,7 @@ void EmbeddedWorkerInstance::StopIfIdle() {
// Check ShouldNotifyWorkerStopIgnored not to show the same message
// multiple times in DevTools.
if (devtools_proxy_->ShouldNotifyWorkerStopIgnored()) {
- AddMessageToConsole(CONSOLE_MESSAGE_LEVEL_DEBUG,
+ AddMessageToConsole(blink::WebConsoleMessage::LevelDebug,
kServiceWorkerTerminationCanceledMesage);
devtools_proxy_->WorkerStopIgnoredNotified();
}
@@ -541,8 +542,8 @@ void EmbeddedWorkerInstance::ResumeAfterDownload() {
status_ != EmbeddedWorkerStatus::STARTING) {
return;
}
- registry_->Send(process_id(), new EmbeddedWorkerMsg_ResumeAfterDownload(
- embedded_worker_id_));
+ DCHECK(client_.is_bound());
+ client_->ResumeAfterDownload();
}
EmbeddedWorkerInstance::EmbeddedWorkerInstance(
@@ -867,14 +868,15 @@ base::TimeDelta EmbeddedWorkerInstance::UpdateStepTime() {
return duration;
}
-void EmbeddedWorkerInstance::AddMessageToConsole(ConsoleMessageLevel level,
- const std::string& message) {
+void EmbeddedWorkerInstance::AddMessageToConsole(
+ blink::WebConsoleMessage::Level level,
+ const std::string& message) {
if (status_ != EmbeddedWorkerStatus::RUNNING &&
status_ != EmbeddedWorkerStatus::STARTING) {
return;
}
- registry_->Send(process_id(), new EmbeddedWorkerMsg_AddMessageToConsole(
- embedded_worker_id_, level, message));
+ DCHECK(client_.is_bound());
+ client_->AddMessageToConsole(level, message);
}
// static

Powered by Google App Engine
This is Rietveld 408576698