Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(671)

Unified Diff: content/browser/service_worker/embedded_worker_instance_unittest.cc

Issue 2630273002: ServiceWorker: mojofy ResumeAfterDownload and AddMessageToConsole (Closed)
Patch Set: Incorporating falken@ and dcheng@ comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/embedded_worker_instance_unittest.cc
diff --git a/content/browser/service_worker/embedded_worker_instance_unittest.cc b/content/browser/service_worker/embedded_worker_instance_unittest.cc
index 240bd4f7360d17ba1cd423edd911a2f949a977b7..e8867cc44fda2afdf056630bf7b081e21f174f95 100644
--- a/content/browser/service_worker/embedded_worker_instance_unittest.cc
+++ b/content/browser/service_worker/embedded_worker_instance_unittest.cc
@@ -521,11 +521,33 @@ TEST_F(EmbeddedWorkerInstanceTest, StopDuringProcessAllocation) {
worker->Stop();
}
+class DontReceiveResumeAfterDownloadInstanceClient
+ : public EmbeddedWorkerTestHelper::MockEmbeddedWorkerInstanceClient {
+ public:
+ explicit DontReceiveResumeAfterDownloadInstanceClient(
+ base::WeakPtr<EmbeddedWorkerTestHelper> helper,
+ bool* is_resume_after_download_called)
+ : EmbeddedWorkerTestHelper::MockEmbeddedWorkerInstanceClient(helper),
+ is_resume_after_download_called_(is_resume_after_download_called) {}
+
+ private:
+ void ResumeAfterDownload() override {
+ *is_resume_after_download_called_ = true;
+ }
+
+ bool* const is_resume_after_download_called_;
falken 2017/01/18 03:57:38 nit: "was_" seems like better grammar
shimazu 2017/01/18 05:00:46 Done.
+};
+
TEST_F(EmbeddedWorkerInstanceTest, StopDuringPausedAfterDownload) {
const int64_t version_id = 55L;
const GURL scope("http://example.com/");
const GURL url("http://example.com/worker.js");
+ bool is_resume_after_download_called = false;
+ helper_->RegisterMockInstanceClient(
+ base::MakeUnique<DontReceiveResumeAfterDownloadInstanceClient>(
+ helper_->AsWeakPtr(), &is_resume_after_download_called));
+
std::unique_ptr<EmbeddedWorkerInstance> worker =
embedded_worker_registry()->CreateWorker();
worker->AddListener(this);
@@ -549,8 +571,7 @@ TEST_F(EmbeddedWorkerInstanceTest, StopDuringPausedAfterDownload) {
// The resume after download message should not have been sent.
EXPECT_EQ(EmbeddedWorkerStatus::STOPPED, worker->status());
- EXPECT_FALSE(ipc_sink()->GetFirstMessageMatching(
- EmbeddedWorkerMsg_ResumeAfterDownload::ID));
+ EXPECT_FALSE(is_resume_after_download_called);
}
TEST_F(EmbeddedWorkerInstanceTest, StopAfterSendingStartWorkerMessage) {

Powered by Google App Engine
This is Rietveld 408576698