third_party/WebKit/public/web/console_message.mojom - Issue 2630273002: ServiceWorker: mojofy ResumeAfterDownload and AddMessageToConsole

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/public/web/console_message.mojom

Issue 2630273002: ServiceWorker: mojofy ResumeAfterDownload and AddMessageToConsole (Closed)

Patch Set: Add a line break Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 module blink.mojom;

	6

	7 enum ConsoleMessageLevel {

	8 Debug = 4,

	9 Log = 1,

	10 Info = 5,

	11 Warning = 2,

	12 Error = 3,

	13 Last = Info
	haraken 2017/01/16 23:48:06 Nit: Shall we sort by the values? Nit: Shall we sort by the values? shimazu 2017/01/17 01:22:04 It's the same order with the definition: https://c Show quoted text On 2017/01/16 23:48:06, haraken wrote: > > Nit: Shall we sort by the values? It's the same order with the definition: https://cs.chromium.org/chromium/src/third_party/WebKit/public/web/WebConsole... It looks sorted by the importance, and using the same order is also reasonable for me. WDYT? (In this case, I should add a comment to mention it.) Is it better to sort by the values?
	14 };

OLD	NEW