[regexp] Create property on result for each named capture

src/regexp/regexp-parser.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/regexp/regexp-parser.h"
 
 #include "src/char-predicates-inl.h"
 #include "src/factory.h"
 #include "src/isolate.h"
 #include "src/objects-inl.h"
@@ skipping 752 matching lines @@
   return name;
 }
 
 bool RegExpParser::CreateNamedCaptureAtIndex(const ZoneVector<uc16>* name,
                                              int index) {
   DCHECK(FLAG_harmony_regexp_named_captures);
   DCHECK(unicode());
   DCHECK(0 < index && index <= captures_started_);
   DCHECK_NOT_NULL(name);
 
+  // Disallow captures named '__proto__'.
+  static const char16_t proto_string[] = u"__proto__";

[Dan Ehrenberg, 2017/01/20 18:23:46]

Sorry I didn't post this comment earlier, but: If adding the properties is
changed from Set to Define I'm not convinced we need to blacklist __proto__.
Instead, if you have a group named __proto__, it would simply create an own
property named __proto__ and not actually change the underlying [[Prototype]].

+  if (name->size() == arraysize(proto_string) - 1) {
+    if (std::equal(name->begin(), name->end(), &proto_string[0])) {
+      ReportError(CStrVector("Illegal capture group name"));
+      return false;
+    }
+  }
+
   if (named_captures_ == nullptr) {
     named_captures_ = new (zone()) ZoneList<RegExpCapture*>(1, zone());
   } else {
     // Check for duplicates and bail if we find any.
     for (const auto& named_capture : *named_captures_) {
       if (*named_capture->name() == *name) {
         ReportError(CStrVector("Duplicate capture group name"));
         return false;
       }
     }
@@ skipping 1010 matching lines @@
     return false;
   }
   terms_.Add(new (zone()) RegExpQuantifier(min, max, quantifier_type, atom),
              zone());
   LAST(ADD_TERM);
   return true;
 }
 
 }  // namespace internal
 }  // namespace v8