Issue 263005: Webkit roll: 49213:49221

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 263005: Webkit roll: 49213:49221 (Closed)

Created:
11 years, 2 months ago by levin

Modified:
9 years, 7 months ago

Reviewers:
Dmitry Titov

CC:
chromium-reviews_googlegroups.com, darin (slow to review), jam

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Webkit roll: 49213:49221 Disabled newly added test for object cloning. TEST=try servers BUG=24063 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28238

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -12 lines)			Patch
M	DEPS	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/api/src/PlatformMessagePortChannel.cpp	View		3 chunks	+4 lines, -2 lines	0 comments	Download
M	webkit/glue/webworker_impl.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/glue/webworker_impl.cc	View		3 chunks	+7 lines, -3 lines	0 comments	Download
M	webkit/glue/webworkerclient_impl.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/glue/webworkerclient_impl.cc	View		4 chunks	+6 lines, -4 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Dmitry Titov

11 years, 2 months ago (2009-10-07 04:06:51 UTC) #2

LGTM with 2 nits

http://codereview.chromium.org/263005/diff/4001/5005
File webkit/glue/webworkerclient_impl.cc (right):

http://codereview.chromium.org/263005/diff/4001/5005#newcode168
Line 168: &PostMessageToWorkerContextTask, this, message->toString(),
channels));
80

http://codereview.chromium.org/263005/diff/4001/5005#newcode355
Line 355: WebCore::MessageEvent::create(ports.release(),
serialized_message.release()));
80

Expand Messages | Collapse Messages