Add mp4 key rotation tests in pipeline integration test

Add mp4 key rotation tests in pipeline integration test

BUG=367366
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269707

[kqyang, 2014-05-02 21:59:40]

Part 4 of supporting ISO BMFF key rotation. 

Please review.

[xhwang, 2014-05-09 04:52:24]

Generally looking good. Just a few nits.

The trybots/commit-queue won't take your binary file when trying your CL. (If
you try now you'll always get failures because test files cannot be found.) So
you need to manually commit the test binaries files first, then start to commit
your CL.

https://codereview.chromium.org/263003003/diff/1/media/filters/pipeline_integ...
File media/filters/pipeline_integration_test.cc (right):

https://codereview.chromium.org/263003003/diff/1/media/filters/pipeline_integ...
media/filters/pipeline_integration_test.cc:256:
EXPECT_TRUE(decryptor->CreateSession(current_session_id_ + 1,
It'll be nice to make sure NeedKey is fired multiple times with different Key
IDs.

https://codereview.chromium.org/263003003/diff/1/media/filters/pipeline_integ...
media/filters/pipeline_integration_test.cc:294: std::rotate(key_id->begin(),
key_id->begin() + pos, key_id->end());
This "rotate" and "key rotation" are two different things. We need more comments
about how the key id and keys are rotating in the file.

https://codereview.chromium.org/263003003/diff/1/media/test/data/README
File media/test/data/README (right):

https://codereview.chromium.org/263003003/diff/1/media/test/data/README#newco...
media/test/data/README:53: bear-640x360-v_frag-cenc-key_rotation.mp4 - A
fragmented MP4 version of the video track of bear-640x360.mp4 encrypted (ISO
CENC) using key ID [1] and key [2] with key rotation.
Please add [3] below explaining in detail how key rotation is done in these new
files. Then refer to [3] here.

[kqyang, 2014-05-09 21:07:25]

PTAL

https://codereview.chromium.org/263003003/diff/1/media/filters/pipeline_integ...
File media/filters/pipeline_integration_test.cc (right):

https://codereview.chromium.org/263003003/diff/1/media/filters/pipeline_integ...
media/filters/pipeline_integration_test.cc:256:
EXPECT_TRUE(decryptor->CreateSession(current_session_id_ + 1,
On 2014/05/09 04:52:24, xhwang wrote:
> It'll be nice to make sure NeedKey is fired multiple times with different Key
> IDs.

Done.

https://codereview.chromium.org/263003003/diff/1/media/filters/pipeline_integ...
media/filters/pipeline_integration_test.cc:294: std::rotate(key_id->begin(),
key_id->begin() + pos, key_id->end());
On 2014/05/09 04:52:24, xhwang wrote:
> This "rotate" and "key rotation" are two different things. We need more
comments
> about how the key id and keys are rotating in the file.

Done.

https://codereview.chromium.org/263003003/diff/1/media/test/data/README
File media/test/data/README (right):

https://codereview.chromium.org/263003003/diff/1/media/test/data/README#newco...
media/test/data/README:53: bear-640x360-v_frag-cenc-key_rotation.mp4 - A
fragmented MP4 version of the video track of bear-640x360.mp4 encrypted (ISO
CENC) using key ID [1] and key [2] with key rotation.
On 2014/05/09 04:52:24, xhwang wrote:
> Please add [3] below explaining in detail how key rotation is done in these
new
> files. Then refer to [3] here.

Done.

This file is moved to another CL: https://codereview.chromium.org/277083002/

[xhwang, 2014-05-09 21:22:01]

lgtm

[kqyang, 2014-05-11 05:48:14]

The CQ bit was checked by kqyang@chromium.org

[commit-bot: I haz the power, 2014-05-11 05:48:26]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kqyang@chromium.org/263003003/40001

[commit-bot: I haz the power, 2014-05-11 14:28:22]

Change committed as 269707