Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1324)

Issue 263003002: Clang update script (Windows): fix asan runtime copying (Closed)

Created:
6 years, 7 months ago by hans
Modified:
6 years, 7 months ago
Reviewers:
Reid Kleckner, Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Clang update script (Windows): fix asan runtime copying Fix the copying of asan runtime. I'll try to come up with a more permanent solution, but this should get the ASan buildbot going in the meantime. BUG=82385 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267932

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M tools/clang/scripts/update.py View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
hans
Please take a look. I'll try to come up with something better, but I really ...
6 years, 7 months ago (2014-05-02 21:31:48 UTC) #1
Nico
lgtm In the long run, I suppose we'll have package.py which will do something similar ...
6 years, 7 months ago (2014-05-02 21:39:48 UTC) #2
hans
On 2014/05/02 21:39:48, Nico wrote: > In the long run, I suppose we'll have package.py ...
6 years, 7 months ago (2014-05-02 21:45:01 UTC) #3
hans
The CQ bit was checked by hans@chromium.org
6 years, 7 months ago (2014-05-02 21:45:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/263003002/1
6 years, 7 months ago (2014-05-02 21:45:41 UTC) #5
Nico
On Fri, May 2, 2014 at 2:45 PM, <hans@chromium.org> wrote: > On 2014/05/02 21:39:48, Nico ...
6 years, 7 months ago (2014-05-02 21:45:55 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-02 21:47:20 UTC) #7
Message was sent while issue was closed.
Change committed as 267932

Powered by Google App Engine
This is Rietveld 408576698