Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2630023003: Report HintCode.MISSING_RETURN for async functions with return type that matters. (Closed)

Created:
3 years, 11 months ago by scheglov
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Report HintCode.MISSING_RETURN for async functions with return type that matters. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/24f61aef203494baabf4effba46a57df4c320536

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -17 lines) Patch
M pkg/analyzer/lib/dart/element/type.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/type.dart View 3 chunks +14 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 1 chunk +13 lines, -5 lines 0 comments Download
M pkg/analyzer/test/generated/hint_code_test.dart View 1 chunk +10 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/non_error_resolver_test.dart View 1 chunk +0 lines, -10 lines 2 comments Download

Messages

Total messages: 6 (1 generated)
scheglov
3 years, 11 months ago (2017-01-14 22:09:09 UTC) #1
Paul Berry
lgtm
3 years, 11 months ago (2017-01-15 14:02:30 UTC) #2
Brian Wilkerson
lgtm https://codereview.chromium.org/2630023003/diff/1/pkg/analyzer/test/generated/non_error_resolver_test.dart File pkg/analyzer/test/generated/non_error_resolver_test.dart (left): https://codereview.chromium.org/2630023003/diff/1/pkg/analyzer/test/generated/non_error_resolver_test.dart#oldcode705 pkg/analyzer/test/generated/non_error_resolver_test.dart:705: test_async_future_object_without_return() async { We should test that we ...
3 years, 11 months ago (2017-01-15 17:22:53 UTC) #3
scheglov
https://codereview.chromium.org/2630023003/diff/1/pkg/analyzer/test/generated/non_error_resolver_test.dart File pkg/analyzer/test/generated/non_error_resolver_test.dart (left): https://codereview.chromium.org/2630023003/diff/1/pkg/analyzer/test/generated/non_error_resolver_test.dart#oldcode705 pkg/analyzer/test/generated/non_error_resolver_test.dart:705: test_async_future_object_without_return() async { On 2017/01/15 17:22:53, Brian Wilkerson wrote: ...
3 years, 11 months ago (2017-01-15 17:48:02 UTC) #4
scheglov
3 years, 11 months ago (2017-01-15 17:51:30 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
24f61aef203494baabf4effba46a57df4c320536 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698