Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Unified Diff: ui/ozone/public/ozone_platform.h

Issue 2629983002: Fix the MessageLoop type in case more than one ozone platform is built (Closed)
Patch Set: Fixed moar feedback from kylechar/fwang Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/ozone/public/ozone_platform.h
diff --git a/ui/ozone/public/ozone_platform.h b/ui/ozone/public/ozone_platform.h
index 236924f01591b3a53d0c52d6959e7854c9f8483f..9666294392941bbf3308ab386feb153f70de6d86 100644
--- a/ui/ozone/public/ozone_platform.h
+++ b/ui/ozone/public/ozone_platform.h
@@ -8,6 +8,7 @@
#include <memory>
#include "base/macros.h"
+#include "base/message_loop/message_loop.h"
#include "ui/ozone/ozone_export.h"
namespace display {
@@ -71,6 +72,8 @@ class OZONE_EXPORT OzonePlatform {
bool single_process = false;
};
+ static void CreateInstance();
sadrul 2017/02/08 01:49:26 Why this change?
tonikitoo 2017/02/08 02:42:34 It creates the OzonePlatform instance without doin
+
// Initializes the subsystems/resources necessary for the UI process (e.g.
// events, etc.)
// TODO(rjkroege): Remove deprecated entry point (http://crbug.com/620934)
@@ -108,6 +111,10 @@ class OZONE_EXPORT OzonePlatform {
virtual std::unique_ptr<display::NativeDisplayDelegate>
CreateNativeDisplayDelegate() = 0;
+ // Returns the message loop type required for OzonePlatform instance that
+ // will be initialized.
+ virtual base::MessageLoop::Type GetMessageLoopTypeForGpu();
sadrul 2017/02/08 01:49:26 Mention in the comment that this is for the gpu pr
tonikitoo 2017/02/08 02:42:34 Done.
+
// Ozone platform implementations may also choose to expose mojo interfaces to
// internal functionality. Embedders wishing to take advantage of ozone mojo
// implementations must invoke AddInterfaces with a valid
@@ -124,8 +131,6 @@ class OZONE_EXPORT OzonePlatform {
virtual void InitializeUI(const InitParams& args);
virtual void InitializeGPU(const InitParams& args);
- static void CreateInstance();
-
static OzonePlatform* instance_;
DISALLOW_COPY_AND_ASSIGN(OzonePlatform);

Powered by Google App Engine
This is Rietveld 408576698