[wasm] Add tests for breakpoints

src/wasm/wasm-debug.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/assembler-inl.h"
 #include "src/assert-scope.h"
 #include "src/compiler/wasm-compiler.h"
 #include "src/debug/debug.h"
 #include "src/factory.h"
 #include "src/frames-inl.h"
@@ skipping 16 matching lines @@
   WasmInterpreter interpreter_;
   Isolate *isolate_;
 
  public:
   // Initialize in the right order, using helper methods to make this possible.
   // WasmInterpreter has to be allocated in place, since it is not movable.
   InterpreterHandle(Isolate *isolate, WasmDebugInfo *debug_info)
       : instance_(debug_info->wasm_instance()->compiled_module()->module()),
         interpreter_(GetBytesEnv(&instance_, debug_info), &allocator_),
         isolate_(isolate) {
-    Handle<JSArrayBuffer> mem_buffer =
-        handle(debug_info->wasm_instance()->memory_buffer(), isolate);
-    if (mem_buffer->IsUndefined(isolate)) {
+    if (debug_info->wasm_instance()->has_memory_buffer()) {
+      JSArrayBuffer *mem_buffer = debug_info->wasm_instance()->memory_buffer();
+      instance_.mem_start =
+          reinterpret_cast<byte *>(mem_buffer->backing_store());

[titzer, 2017/01/16 13:55:27]

byte* instead of byte *

(I guess clang-format is accepting both these days?)

[Clemens Hammacher, 2017/01/16 18:51:30]

Fixed with http://crrev.com/2635003002 and http://crrev.com/2631183002.

+      CHECK(mem_buffer->byte_length()->ToUint32(&instance_.mem_size));
+    } else {
       DCHECK_EQ(0, instance_.module->min_mem_pages);
       instance_.mem_start = nullptr;
       instance_.mem_size = 0;
-    } else {
-      instance_.mem_start =
-          reinterpret_cast<byte *>(mem_buffer->backing_store());
-      CHECK(mem_buffer->byte_length()->ToUint32(&instance_.mem_size));
     }
   }
 
   static ModuleBytesEnv GetBytesEnv(WasmInstance *instance,
                                     WasmDebugInfo *debug_info) {
     // Return raw pointer into heap. The WasmInterpreter will make its own copy
     // of this data anyway, and there is no heap allocation in-between.
     SeqOneByteString *bytes_str =
         debug_info->wasm_instance()->compiled_module()->module_bytes();
     Vector<const byte> bytes(bytes_str->GetChars(), bytes_str->length());
@@ skipping 250 matching lines @@
   return interp_handle->GetInterpretedStack(frame_pointer);
 }
 
 std::unique_ptr<wasm::InterpretedFrame> WasmDebugInfo::GetInterpretedFrame(
     Handle<WasmDebugInfo> debug_info, Address frame_pointer, int idx) {
   InterpreterHandle *interp_handle =
       GetOrCreateInterpreterHandle(debug_info->GetIsolate(), debug_info);
   return std::unique_ptr<wasm::InterpretedFrame>(new wasm::InterpretedFrame(
       interp_handle->GetInterpretedFrame(frame_pointer, idx)));
 }