Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1321)

Unified Diff: third_party/WebKit/Source/platform/heap/HeapPage.h

Issue 2629853002: Add NOTREACHED to HeapObjectHeader::markDead() (Closed)
Patch Set: temp Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/heap/HeapPage.h
diff --git a/third_party/WebKit/Source/platform/heap/HeapPage.h b/third_party/WebKit/Source/platform/heap/HeapPage.h
index 69d369dc9ef587180b79c1c9ae17260cbd4b794c..8fbc94a78461f9ebb95f6373b040ffee9f05e317 100644
--- a/third_party/WebKit/Source/platform/heap/HeapPage.h
+++ b/third_party/WebKit/Source/platform/heap/HeapPage.h
@@ -925,6 +925,9 @@ NO_SANITIZE_ADDRESS inline bool HeapObjectHeader::isDead() const {
}
NO_SANITIZE_ADDRESS inline void HeapObjectHeader::markDead() {
+ // A Dead state should not happen in a per-thread heap world.
+ // TODO(haraken): Remove code to handle the Dead state.
+ CHECK(false);
ASSERT(checkHeader());
ASSERT(!isMarked());
m_encoded |= headerDeadBitMask;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698