Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: src/debug/debug.cc

Issue 2629823003: [wasm] Implement frame inspection for interpreted frames (Closed)
Patch Set: Rebase after Yangs revert ಠ益ಠ Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/debug/debug-frames.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug/debug.cc
diff --git a/src/debug/debug.cc b/src/debug/debug.cc
index 35f9a7350f9091c36e45214878eed7a451cf5ec8..2c763915bd451bc9f55f9dbc9d07b805fb4971a8 100644
--- a/src/debug/debug.cc
+++ b/src/debug/debug.cc
@@ -2317,9 +2317,9 @@ void Debug::ProcessDebugMessages(bool debug_command_only) {
void Debug::PrintBreakLocation() {
if (!FLAG_print_break_location) return;
HandleScope scope(isolate_);
- JavaScriptFrameIterator iterator(isolate_);
+ StackTraceFrameIterator iterator(isolate_);
if (iterator.done()) return;
- JavaScriptFrame* frame = iterator.frame();
+ StandardFrame* frame = iterator.frame();
FrameSummary summary = FrameSummary::GetTop(frame);
int source_position = summary.SourcePosition();
Handle<Object> script_obj = summary.script();
@@ -2372,8 +2372,6 @@ DebugScope::DebugScope(Debug* debug)
// frame id.
StackTraceFrameIterator it(isolate());
bool has_frames = !it.done();
- // We don't currently support breaking inside wasm framess.
- DCHECK(!has_frames || !it.is_wasm());
debug_->thread_local_.break_frame_id_ =
has_frames ? it.frame()->id() : StackFrame::NO_ID;
debug_->SetNextBreakId();
« no previous file with comments | « no previous file | src/debug/debug-frames.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698