Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: extensions/browser/bad_message.cc

Issue 2629783002: Upload crash reports when ExtensionFunctions generate bad messages. (Closed)
Patch Set: sync Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/bad_message.h ('k') | extensions/browser/extension_function_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/bad_message.cc
diff --git a/extensions/browser/bad_message.cc b/extensions/browser/bad_message.cc
index da8edbc440315c4067e4e140e033dcac99aa6afc..a88b61276b9ce473d1a3ca864ab1a4fb838b59d7 100644
--- a/extensions/browser/bad_message.cc
+++ b/extensions/browser/bad_message.cc
@@ -15,6 +15,10 @@ namespace bad_message {
namespace {
void LogBadMessage(BadMessageReason reason) {
+ // TODO(creis): We should add a crash key similar to the "bad_message_reason"
+ // key logged in content::bad_message::ReceivedBadMessage, for disambiguating
+ // multiple kills in the same method. It's important not to overlap with the
+ // content::bad_message::BadMessageReason enum values.
LOG(ERROR) << "Terminating extension renderer for bad IPC message, reason "
<< reason;
UMA_HISTOGRAM_SPARSE_SLOWLY("Stability.BadMessageTerminated.Extensions",
« no previous file with comments | « extensions/browser/bad_message.h ('k') | extensions/browser/extension_function_dispatcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698