Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2901)

Unified Diff: extensions/browser/bad_message.cc

Issue 2629783002: Upload crash reports when ExtensionFunctions generate bad messages. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/bad_message.cc
diff --git a/extensions/browser/bad_message.cc b/extensions/browser/bad_message.cc
index da8edbc440315c4067e4e140e033dcac99aa6afc..ee8927896681da10585613aa387c1ae64ef29c82 100644
--- a/extensions/browser/bad_message.cc
+++ b/extensions/browser/bad_message.cc
@@ -15,6 +15,16 @@ namespace bad_message {
namespace {
void LogBadMessage(BadMessageReason reason) {
+ // EFD_BAD_MESSAGE uses different logging and UMA.
+ // See callers of ReceivedBadMessage() in ExtensionFunctionDispatcher.
+ if (reason == EFD_BAD_MESSAGE)
+ return;
+
+ // TODO(creis): We should call SetCrashKeyValue("bad_message_reason") similar
lazyboy 2017/01/13 01:11:51 @creis: As you've said: we use string version of |
+ // to the content/ implementation, so the generated crash reports are
+ // easier to search. Not straightforward because
+ // extensions::bad_message::BadMessageReason and
+ // content::bad_message::BadMessageReason enum values overlap.
LOG(ERROR) << "Terminating extension renderer for bad IPC message, reason "
<< reason;
UMA_HISTOGRAM_SPARSE_SLOWLY("Stability.BadMessageTerminated.Extensions",

Powered by Google App Engine
This is Rietveld 408576698