Chromium Code Reviews| Index: extensions/browser/bad_message.cc |
| diff --git a/extensions/browser/bad_message.cc b/extensions/browser/bad_message.cc |
| index da8edbc440315c4067e4e140e033dcac99aa6afc..ee8927896681da10585613aa387c1ae64ef29c82 100644 |
| --- a/extensions/browser/bad_message.cc |
| +++ b/extensions/browser/bad_message.cc |
| @@ -15,6 +15,16 @@ namespace bad_message { |
| namespace { |
| void LogBadMessage(BadMessageReason reason) { |
| + // EFD_BAD_MESSAGE uses different logging and UMA. |
| + // See callers of ReceivedBadMessage() in ExtensionFunctionDispatcher. |
| + if (reason == EFD_BAD_MESSAGE) |
| + return; |
| + |
| + // TODO(creis): We should call SetCrashKeyValue("bad_message_reason") similar |
|
lazyboy
2017/01/13 01:11:51
@creis: As you've said: we use string version of |
|
| + // to the content/ implementation, so the generated crash reports are |
| + // easier to search. Not straightforward because |
| + // extensions::bad_message::BadMessageReason and |
| + // content::bad_message::BadMessageReason enum values overlap. |
| LOG(ERROR) << "Terminating extension renderer for bad IPC message, reason " |
| << reason; |
| UMA_HISTOGRAM_SPARSE_SLOWLY("Stability.BadMessageTerminated.Extensions", |