Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Side by Side Diff: extensions/browser/bad_message.h

Issue 2629783002: Upload crash reports when ExtensionFunctions generate bad messages. (Closed)
Patch Set: address comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | extensions/browser/bad_message.cc » ('j') | extensions/browser/bad_message.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_BROWSER_BAD_MESSAGE_H_ 5 #ifndef EXTENSIONS_BROWSER_BAD_MESSAGE_H_
6 #define EXTENSIONS_BROWSER_BAD_MESSAGE_H_ 6 #define EXTENSIONS_BROWSER_BAD_MESSAGE_H_
7 7
8 namespace content { 8 namespace content {
9 class BrowserMessageFilter; 9 class BrowserMessageFilter;
10 class RenderProcessHost; 10 class RenderProcessHost;
(...skipping 13 matching lines...) Expand all
24 enum BadMessageReason { 24 enum BadMessageReason {
25 EOG_BAD_ORIGIN = 0, 25 EOG_BAD_ORIGIN = 0,
26 EVG_BAD_ORIGIN = 1, 26 EVG_BAD_ORIGIN = 1,
27 BH_BLOB_NOT_OWNED = 2, 27 BH_BLOB_NOT_OWNED = 2,
28 EH_BAD_EVENT_ID = 3, 28 EH_BAD_EVENT_ID = 3,
29 AVG_BAD_INST_ID = 4, 29 AVG_BAD_INST_ID = 4,
30 AVG_BAD_EXT_ID = 5, 30 AVG_BAD_EXT_ID = 5,
31 AVG_NULL_AVG = 6, 31 AVG_NULL_AVG = 6,
32 // Invalid decrement of an Extensions SW ref count. 32 // Invalid decrement of an Extensions SW ref count.
33 ESWMF_INVALID_DECREMENT_ACTIVITY = 7, 33 ESWMF_INVALID_DECREMENT_ACTIVITY = 7,
34 EFD_BAD_MESSAGE = 8,
34 // Please add new elements here. The naming convention is abbreviated class 35 // Please add new elements here. The naming convention is abbreviated class
35 // name (e.g. ExtensionHost becomes EH) plus a unique description of the 36 // name (e.g. ExtensionHost becomes EH) plus a unique description of the
36 // reason. After making changes, you MUST update histograms.xml by running: 37 // reason. After making changes, you MUST update histograms.xml by running:
37 // "python tools/metrics/histograms/update_bad_message_reasons.py" 38 // "python tools/metrics/histograms/update_bad_message_reasons.py"
38 BAD_MESSAGE_MAX 39 BAD_MESSAGE_MAX
39 }; 40 };
40 41
41 // Called when the browser receives a bad IPC message from an extension process. 42 // Called when the browser receives a bad IPC message from an extension process.
42 // Logs the event, records a histogram metric for the |reason|, and terminates 43 // Logs the event, records a histogram metric for the |reason|, and terminates
43 // the process for |host|. 44 // the process for |host|.
44 void ReceivedBadMessage(content::RenderProcessHost* host, 45 void ReceivedBadMessage(content::RenderProcessHost* host,
45 BadMessageReason reason); 46 BadMessageReason reason);
46 47
47 // Called when a browser message filter receives a bad IPC message from a 48 // Called when a browser message filter receives a bad IPC message from a
48 // renderer or other child process. Logs the event, records a histogram metric 49 // renderer or other child process. Logs the event, records a histogram metric
49 // for the |reason|, and terminates the process for |filter|. 50 // for the |reason|, and terminates the process for |filter|.
50 void ReceivedBadMessage(content::BrowserMessageFilter* filter, 51 void ReceivedBadMessage(content::BrowserMessageFilter* filter,
51 BadMessageReason reason); 52 BadMessageReason reason);
52 53
53 } // namespace bad_message 54 } // namespace bad_message
54 } // namespace extensions 55 } // namespace extensions
55 56
56 #endif // EXTENSIONS_BROWSER_BAD_MESSAGE_H_ 57 #endif // EXTENSIONS_BROWSER_BAD_MESSAGE_H_
OLDNEW
« no previous file with comments | « no previous file | extensions/browser/bad_message.cc » ('j') | extensions/browser/bad_message.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698