Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1216)

Unified Diff: content/browser/bad_message.cc

Issue 2629773002: Always set bad_message_reason when logging bad message dumps (Closed)
Patch Set: . Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/bad_message.cc
diff --git a/content/browser/bad_message.cc b/content/browser/bad_message.cc
index 487742be1a893d8a209e251052e022ef92c4bcf9..ee8fba472bf1bbf39fb37334d0cdb4e00858a5be 100644
--- a/content/browser/bad_message.cc
+++ b/content/browser/bad_message.cc
@@ -33,8 +33,6 @@ void ReceivedBadMessageOnUIThread(int render_process_id,
if (!host)
return;
- LogBadMessage(reason);
-
// A dump has already been generated by the caller. Don't generate another.
host->ShutdownForBadMessage(
RenderProcessHost::CrashReportMode::NO_CRASH_DUMP);
@@ -49,8 +47,9 @@ void ReceivedBadMessage(RenderProcessHost* host, BadMessageReason reason) {
}
void ReceivedBadMessage(int render_process_id, BadMessageReason reason) {
- // We generate a crash dump here since generating one after posting the UI
- // thread is mostly useless.
+ // We generate a crash dump here since generating one after posting to the UI
+ // thread is less useful.
+ LogBadMessage(reason);
base::debug::DumpWithoutCrashing();
if (!BrowserThread::CurrentlyOn(BrowserThread::UI)) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698