Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Unified Diff: net/quic/core/quic_stream_sequencer.cc

Issue 2629723003: Revert of Add quic_logging (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_stream.cc ('k') | net/quic/core/quic_stream_sequencer_buffer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_stream_sequencer.cc
diff --git a/net/quic/core/quic_stream_sequencer.cc b/net/quic/core/quic_stream_sequencer.cc
index 941a670e1d59a889794d9b8d98385a59828ef2c6..3b28311829c57ec386b9c77c22823d9b9a0060b6 100644
--- a/net/quic/core/quic_stream_sequencer.cc
+++ b/net/quic/core/quic_stream_sequencer.cc
@@ -10,6 +10,7 @@
#include <utility>
#include "base/format_macros.h"
+#include "base/logging.h"
#include "net/quic/core/quic_flags.h"
#include "net/quic/core/quic_packets.h"
#include "net/quic/core/quic_stream.h"
@@ -17,7 +18,6 @@
#include "net/quic/core/quic_utils.h"
#include "net/quic/platform/api/quic_bug_tracker.h"
#include "net/quic/platform/api/quic_clock.h"
-#include "net/quic/platform/api/quic_logging.h"
#include "net/quic/platform/api/quic_str_cat.h"
using base::StringPiece;
@@ -59,8 +59,8 @@
"Stream ", stream_->id(), ": ", QuicErrorCodeToString(result), ": ",
error_details, "\nPeer Address: ",
stream_->PeerAddressOfLatestPacket().ToString());
- QUIC_LOG_FIRST_N(WARNING, 50) << QuicErrorCodeToString(result);
- QUIC_LOG_FIRST_N(WARNING, 50) << details;
+ DLOG(WARNING) << QuicErrorCodeToString(result);
+ DLOG(WARNING) << details;
stream_->CloseConnectionWithDetails(result, details);
return;
}
@@ -104,9 +104,9 @@
return false;
}
- QUIC_DVLOG(1) << "Passing up termination, as we've processed "
- << buffered_frames_.BytesConsumed() << " of " << close_offset_
- << " bytes.";
+ DVLOG(1) << "Passing up termination, as we've processed "
+ << buffered_frames_.BytesConsumed() << " of " << close_offset_
+ << " bytes.";
// This will cause the stream to consume the FIN.
// Technically it's an error if |num_bytes_consumed| isn't exactly
// equal to |close_offset|, but error handling seems silly at this point.
@@ -201,9 +201,9 @@
void QuicStreamSequencer::FlushBufferedFrames() {
DCHECK(ignore_read_data_);
size_t bytes_flushed = buffered_frames_.FlushBufferedFrames();
- QUIC_DVLOG(1) << "Flushing buffered data at offset "
- << buffered_frames_.BytesConsumed() << " length "
- << bytes_flushed << " for stream " << stream_->id();
+ DVLOG(1) << "Flushing buffered data at offset "
+ << buffered_frames_.BytesConsumed() << " length " << bytes_flushed
+ << " for stream " << stream_->id();
stream_->AddBytesConsumed(bytes_flushed);
MaybeCloseStream();
}
« no previous file with comments | « net/quic/core/quic_stream.cc ('k') | net/quic/core/quic_stream_sequencer_buffer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698