| Index: net/quic/core/quic_framer.cc
|
| diff --git a/net/quic/core/quic_framer.cc b/net/quic/core/quic_framer.cc
|
| index 6f48b2fd905428a25233a80b16e808ccbf354bd4..d2e7069989a8d54111e2e6500915e349edc8c0e6 100644
|
| --- a/net/quic/core/quic_framer.cc
|
| +++ b/net/quic/core/quic_framer.cc
|
| @@ -8,6 +8,7 @@
|
| #include <memory>
|
|
|
| #include "base/compiler_specific.h"
|
| +#include "base/logging.h"
|
| #include "base/memory/ptr_util.h"
|
| #include "base/stl_util.h"
|
| #include "net/quic/core/crypto/crypto_framer.h"
|
| @@ -24,7 +25,6 @@
|
| #include "net/quic/core/quic_utils.h"
|
| #include "net/quic/platform/api/quic_aligned.h"
|
| #include "net/quic/platform/api/quic_bug_tracker.h"
|
| -#include "net/quic/platform/api/quic_logging.h"
|
|
|
| using base::ContainsKey;
|
| using base::StringPiece;
|
| @@ -308,8 +308,8 @@
|
| if (can_truncate) {
|
| // Truncate the frame so the packet will not exceed kMaxPacketSize.
|
| // Note that we may not use every byte of the writer in this case.
|
| - QUIC_DLOG(INFO) << ENDPOINT
|
| - << "Truncating large frame, free bytes: " << free_bytes;
|
| + DVLOG(1) << ENDPOINT
|
| + << "Truncating large frame, free bytes: " << free_bytes;
|
| return free_bytes;
|
| }
|
| return 0;
|
| @@ -506,8 +506,8 @@
|
| QuicPacketPublicHeader public_header;
|
| if (!ProcessPublicHeader(&reader, &public_header)) {
|
| DCHECK_NE("", detailed_error_);
|
| - QUIC_DVLOG(1) << ENDPOINT << "Unable to process public header. Error: "
|
| - << detailed_error_;
|
| + DVLOG(1) << ENDPOINT
|
| + << "Unable to process public header. Error: " << detailed_error_;
|
| DCHECK_NE("", detailed_error_);
|
| return RaiseError(QUIC_INVALID_PACKET_HEADER);
|
| }
|
| @@ -572,10 +572,9 @@
|
| QuicPacketHeader header(public_header);
|
| if (!ProcessUnauthenticatedHeader(encrypted_reader, &header)) {
|
| DCHECK_NE("", detailed_error_);
|
| - QUIC_DVLOG(1)
|
| - << ENDPOINT
|
| - << "Unable to process packet header. Stopping parsing. Error: "
|
| - << detailed_error_;
|
| + DVLOG(1) << ENDPOINT
|
| + << "Unable to process packet header. Stopping parsing. Error: "
|
| + << detailed_error_;
|
| return false;
|
| }
|
|
|
| @@ -607,8 +606,8 @@
|
| if (!ProcessFrameData(&reader, header)) {
|
| DCHECK_NE(QUIC_NO_ERROR, error_); // ProcessFrameData sets the error.
|
| DCHECK_NE("", detailed_error_);
|
| - QUIC_DLOG(WARNING) << ENDPOINT << "Unable to process frame data. Error: "
|
| - << detailed_error_;
|
| + DLOG(WARNING) << ENDPOINT
|
| + << "Unable to process frame data. Error: " << detailed_error_;
|
| return false;
|
| }
|
|
|
| @@ -653,7 +652,7 @@
|
|
|
| bool QuicFramer::AppendPacketHeader(const QuicPacketHeader& header,
|
| QuicDataWriter* writer) {
|
| - QUIC_DVLOG(1) << ENDPOINT << "Appending header: " << header;
|
| + DVLOG(1) << ENDPOINT << "Appending header: " << header;
|
| uint8_t public_flags = 0;
|
| if (header.public_header.reset_flag) {
|
| public_flags |= PACKET_PUBLIC_FLAGS_RST;
|
| @@ -699,8 +698,8 @@
|
| DCHECK_EQ(Perspective::IS_CLIENT, perspective_);
|
| QuicTag tag = QuicVersionToQuicTag(quic_version_);
|
| writer->WriteUInt32(tag);
|
| - QUIC_DVLOG(1) << ENDPOINT << "version = " << quic_version_ << ", tag = '"
|
| - << QuicTagToString(tag) << "'";
|
| + DVLOG(1) << ENDPOINT << "version = " << quic_version_ << ", tag = '"
|
| + << QuicTagToString(tag) << "'";
|
| }
|
|
|
| if (header.public_header.multipath_flag &&
|
| @@ -1039,8 +1038,7 @@
|
| return RaiseError(QUIC_INVALID_STREAM_DATA);
|
| }
|
| if (!visitor_->OnStreamFrame(frame)) {
|
| - QUIC_DVLOG(1) << ENDPOINT
|
| - << "Visitor asked to stop further processing.";
|
| + DVLOG(1) << ENDPOINT << "Visitor asked to stop further processing.";
|
| // Returning true since there was no parsing error.
|
| return true;
|
| }
|
| @@ -1054,8 +1052,7 @@
|
| return RaiseError(QUIC_INVALID_ACK_DATA);
|
| }
|
| if (!visitor_->OnAckFrame(frame)) {
|
| - QUIC_DVLOG(1) << ENDPOINT
|
| - << "Visitor asked to stop further processing.";
|
| + DVLOG(1) << ENDPOINT << "Visitor asked to stop further processing.";
|
| // Returning true since there was no parsing error.
|
| return true;
|
| }
|
| @@ -1065,8 +1062,8 @@
|
| // This was a special frame type that did not match any
|
| // of the known ones. Error.
|
| set_detailed_error("Illegal frame type.");
|
| - QUIC_DLOG(WARNING) << ENDPOINT << "Illegal frame type: "
|
| - << static_cast<int>(frame_type);
|
| + DLOG(WARNING) << ENDPOINT
|
| + << "Illegal frame type: " << static_cast<int>(frame_type);
|
| return RaiseError(QUIC_INVALID_FRAME_DATA);
|
| }
|
|
|
| @@ -1074,7 +1071,7 @@
|
| case PADDING_FRAME: {
|
| QuicPaddingFrame frame(reader->BytesRemaining());
|
| if (!visitor_->OnPaddingFrame(frame)) {
|
| - QUIC_DVLOG(1) << "Visitor asked to stop further processing.";
|
| + DVLOG(1) << "Visitor asked to stop further processing.";
|
| }
|
| // We're done with the packet.
|
| return true;
|
| @@ -1086,7 +1083,7 @@
|
| return RaiseError(QUIC_INVALID_RST_STREAM_DATA);
|
| }
|
| if (!visitor_->OnRstStreamFrame(frame)) {
|
| - QUIC_DVLOG(1) << "Visitor asked to stop further processing.";
|
| + DVLOG(1) << "Visitor asked to stop further processing.";
|
| // Returning true since there was no parsing error.
|
| return true;
|
| }
|
| @@ -1100,8 +1097,7 @@
|
| }
|
|
|
| if (!visitor_->OnConnectionCloseFrame(frame)) {
|
| - QUIC_DVLOG(1) << ENDPOINT
|
| - << "Visitor asked to stop further processing.";
|
| + DVLOG(1) << ENDPOINT << "Visitor asked to stop further processing.";
|
| // Returning true since there was no parsing error.
|
| return true;
|
| }
|
| @@ -1114,8 +1110,7 @@
|
| return RaiseError(QUIC_INVALID_GOAWAY_DATA);
|
| }
|
| if (!visitor_->OnGoAwayFrame(goaway_frame)) {
|
| - QUIC_DVLOG(1) << ENDPOINT
|
| - << "Visitor asked to stop further processing.";
|
| + DVLOG(1) << ENDPOINT << "Visitor asked to stop further processing.";
|
| // Returning true since there was no parsing error.
|
| return true;
|
| }
|
| @@ -1128,8 +1123,7 @@
|
| return RaiseError(QUIC_INVALID_WINDOW_UPDATE_DATA);
|
| }
|
| if (!visitor_->OnWindowUpdateFrame(window_update_frame)) {
|
| - QUIC_DVLOG(1) << ENDPOINT
|
| - << "Visitor asked to stop further processing.";
|
| + DVLOG(1) << ENDPOINT << "Visitor asked to stop further processing.";
|
| // Returning true since there was no parsing error.
|
| return true;
|
| }
|
| @@ -1142,8 +1136,7 @@
|
| return RaiseError(QUIC_INVALID_BLOCKED_DATA);
|
| }
|
| if (!visitor_->OnBlockedFrame(blocked_frame)) {
|
| - QUIC_DVLOG(1) << ENDPOINT
|
| - << "Visitor asked to stop further processing.";
|
| + DVLOG(1) << ENDPOINT << "Visitor asked to stop further processing.";
|
| // Returning true since there was no parsing error.
|
| return true;
|
| }
|
| @@ -1156,8 +1149,7 @@
|
| return RaiseError(QUIC_INVALID_STOP_WAITING_DATA);
|
| }
|
| if (!visitor_->OnStopWaitingFrame(stop_waiting_frame)) {
|
| - QUIC_DVLOG(1) << ENDPOINT
|
| - << "Visitor asked to stop further processing.";
|
| + DVLOG(1) << ENDPOINT << "Visitor asked to stop further processing.";
|
| // Returning true since there was no parsing error.
|
| return true;
|
| }
|
| @@ -1167,8 +1159,7 @@
|
| // Ping has no payload.
|
| QuicPingFrame ping_frame;
|
| if (!visitor_->OnPingFrame(ping_frame)) {
|
| - QUIC_DVLOG(1) << ENDPOINT
|
| - << "Visitor asked to stop further processing.";
|
| + DVLOG(1) << ENDPOINT << "Visitor asked to stop further processing.";
|
| // Returning true since there was no parsing error.
|
| return true;
|
| }
|
| @@ -1180,8 +1171,7 @@
|
| return RaiseError(QUIC_INVALID_PATH_CLOSE_DATA);
|
| }
|
| if (!visitor_->OnPathCloseFrame(path_close_frame)) {
|
| - QUIC_DVLOG(1) << ENDPOINT
|
| - << "Visitor asked to stop further processing.";
|
| + DVLOG(1) << ENDPOINT << "Visitor asked to stop further processing.";
|
| // Returning true since there was no parsing error.
|
| return true;
|
| }
|
| @@ -1190,8 +1180,8 @@
|
|
|
| default:
|
| set_detailed_error("Illegal frame type.");
|
| - QUIC_DLOG(WARNING) << ENDPOINT << "Illegal frame type: "
|
| - << static_cast<int>(frame_type);
|
| + DLOG(WARNING) << ENDPOINT
|
| + << "Illegal frame type: " << static_cast<int>(frame_type);
|
| return RaiseError(QUIC_INVALID_FRAME_DATA);
|
| }
|
| }
|
| @@ -1691,8 +1681,8 @@
|
| }
|
|
|
| if (!success) {
|
| - QUIC_DVLOG(1) << ENDPOINT << "DecryptPacket failed for packet_number:"
|
| - << header.packet_number;
|
| + DVLOG(1) << ENDPOINT << "DecryptPacket failed for packet_number:"
|
| + << header.packet_number;
|
| return false;
|
| }
|
|
|
| @@ -2209,8 +2199,8 @@
|
| }
|
|
|
| bool QuicFramer::RaiseError(QuicErrorCode error) {
|
| - QUIC_DLOG(INFO) << ENDPOINT << "Error: " << QuicErrorCodeToString(error)
|
| - << " detail: " << detailed_error_;
|
| + DVLOG(1) << ENDPOINT << "Error: " << QuicErrorCodeToString(error)
|
| + << " detail: " << detailed_error_;
|
| set_error(error);
|
| visitor_->OnError(this);
|
| return false;
|
|
|