Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Unified Diff: net/quic/core/crypto/p256_key_exchange.cc

Issue 2629723003: Revert of Add quic_logging (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/core/crypto/p256_key_exchange.cc
diff --git a/net/quic/core/crypto/p256_key_exchange.cc b/net/quic/core/crypto/p256_key_exchange.cc
index 1e4d956ed99ca271f51c63f3ecfb6b9d47190d8f..62a58903354f479fa223d1b9df0bdec499cfb4e9 100644
--- a/net/quic/core/crypto/p256_key_exchange.cc
+++ b/net/quic/core/crypto/p256_key_exchange.cc
@@ -9,7 +9,7 @@
#include <string>
#include <utility>
-#include "net/quic/platform/api/quic_logging.h"
+#include "base/logging.h"
#include "third_party/boringssl/src/include/openssl/ec.h"
#include "third_party/boringssl/src/include/openssl/ecdh.h"
#include "third_party/boringssl/src/include/openssl/err.h"
@@ -31,7 +31,7 @@
// static
P256KeyExchange* P256KeyExchange::New(StringPiece key) {
if (key.empty()) {
- QUIC_DLOG(INFO) << "Private key is empty";
+ DVLOG(1) << "Private key is empty";
return nullptr;
}
@@ -39,7 +39,7 @@
bssl::UniquePtr<EC_KEY> private_key(
d2i_ECPrivateKey(nullptr, &keyp, key.size()));
if (!private_key.get() || !EC_KEY_check_key(private_key.get())) {
- QUIC_DLOG(INFO) << "Private key is invalid.";
+ DVLOG(1) << "Private key is invalid.";
return nullptr;
}
@@ -48,7 +48,7 @@
EC_KEY_get0_public_key(private_key.get()),
POINT_CONVERSION_UNCOMPRESSED, public_key,
sizeof(public_key), nullptr) != sizeof(public_key)) {
- QUIC_DLOG(INFO) << "Can't get public key.";
+ DVLOG(1) << "Can't get public key.";
return nullptr;
}
@@ -59,19 +59,19 @@
string P256KeyExchange::NewPrivateKey() {
bssl::UniquePtr<EC_KEY> key(EC_KEY_new_by_curve_name(NID_X9_62_prime256v1));
if (!key.get() || !EC_KEY_generate_key(key.get())) {
- QUIC_DLOG(INFO) << "Can't generate a new private key.";
+ DVLOG(1) << "Can't generate a new private key.";
return string();
}
int key_len = i2d_ECPrivateKey(key.get(), nullptr);
if (key_len <= 0) {
- QUIC_DLOG(INFO) << "Can't convert private key to string";
+ DVLOG(1) << "Can't convert private key to string";
return string();
}
std::unique_ptr<uint8_t[]> private_key(new uint8_t[key_len]);
uint8_t* keyp = private_key.get();
if (!i2d_ECPrivateKey(key.get(), &keyp)) {
- QUIC_DLOG(INFO) << "Can't convert private key to string.";
+ DVLOG(1) << "Can't convert private key to string.";
return string();
}
return string(reinterpret_cast<char*>(private_key.get()), key_len);
@@ -86,7 +86,7 @@
bool P256KeyExchange::CalculateSharedKey(StringPiece peer_public_value,
string* out_result) const {
if (peer_public_value.size() != kUncompressedP256PointBytes) {
- QUIC_DLOG(INFO) << "Peer public value is invalid";
+ DVLOG(1) << "Peer public value is invalid";
return false;
}
@@ -98,14 +98,14 @@
reinterpret_cast<const uint8_t*>(
peer_public_value.data()),
peer_public_value.size(), nullptr)) {
- QUIC_DLOG(INFO) << "Can't convert peer public value to curve point.";
+ DVLOG(1) << "Can't convert peer public value to curve point.";
return false;
}
uint8_t result[kP256FieldBytes];
if (ECDH_compute_key(result, sizeof(result), point.get(), private_key_.get(),
nullptr) != sizeof(result)) {
- QUIC_DLOG(INFO) << "Can't compute ECDH shared key.";
+ DVLOG(1) << "Can't compute ECDH shared key.";
return false;
}
« no previous file with comments | « net/quic/core/crypto/curve25519_key_exchange.cc ('k') | net/quic/core/crypto/quic_compressed_certs_cache_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698