Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Unified Diff: tools/rebaseline.py

Issue 26297004: More work to integrate skimage with rebaseline tools. (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: Respond to comments. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/rebaseline.py
diff --git a/tools/rebaseline.py b/tools/rebaseline.py
index 76bbfe828ee6947310e5d2d511432212d536a139..f42c70d10fa163f0c5418383d74a8765cc41b9fd 100755
--- a/tools/rebaseline.py
+++ b/tools/rebaseline.py
@@ -378,8 +378,7 @@ parser.add_argument('--configs', metavar='CONFIG', nargs='+',
help=('which configurations to rebaseline, e.g. '
'"--configs 565 8888", as a filter over the full set '
'of results in ACTUALS_FILENAME; if unspecified, '
- 'rebaseline *all* configs that are available. '
- 'Ignored if SKIMAGE is True.'))
+ 'rebaseline *all* configs that are available.'))
parser.add_argument('--expectations-filename',
help=('filename (under EXPECTATIONS_ROOT) to read '
'current expectations from, and to write new '
@@ -412,7 +411,7 @@ parser.add_argument('--tests', metavar='TEST', nargs='+',
'"--tests aaclip bigmatrix", as a filter over the '
'full set of results in ACTUALS_FILENAME; if '
'unspecified, rebaseline *all* tests that are '
- 'available. Ignored if SKIMAGE is True.'))
+ 'available.'))
parser.add_argument('--unreviewed', action='store_true',
help=('mark all expectations modified by this run as '
'"%s": False' %
@@ -444,9 +443,6 @@ if args.skimage:
args.actuals_base_url = gm_json.SKIMAGE_ACTUALS_BASE_URL
if args.expectations_root == parser.get_default('expectations_root'):
args.expectations_root = gm_json.SKIMAGE_EXPECTATIONS_ROOT
- # Also ignore TESTS and CONFIGS
- args.tests = None
- args.configs = None
for builder in builders:
if not builder in TEST_BUILDERS:
raise Exception(('unrecognized builder "%s"; ' +
« no previous file with comments | « gm/gm_expectations.cpp ('k') | tools/skimage_main.cpp » ('j') | tools/skimage_main.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698