Refactor GL bindings so there is no global GLApi or DriverGL.

ui/gl/gl_api_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdint.h>
 
 #include <memory>
 
 #include "base/command_line.h"
 #include "base/macros.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/gl/gl_context.h"
 #include "ui/gl/gl_gl_api_implementation.h"
 #include "ui/gl/gl_implementation.h"
 #include "ui/gl/gl_switches.h"
+#include "ui/gl/gl_version_info.h"
 #include "ui/gl/gpu_timing.h"
 
 namespace gl {
 
-class GLContextFake : public GLContext {
- public:
-  bool Initialize(GLSurface* compatible_surface,
-                  const GLContextAttribs& attribs) override {
-    return true;
-  }
-  bool MakeCurrent(GLSurface* surface) override { return true; }
-  void ReleaseCurrent(GLSurface* surface) override {}
-  bool IsCurrent(GLSurface* surface) override { return true; }
-  void* GetHandle() override { return NULL; }
-  scoped_refptr<GPUTimingClient> CreateGPUTimingClient() override {
-    return NULL;
-  }
-  void OnSetSwapInterval(int interval) override {}
-  GLContextFake() : GLContext(NULL) {}
- protected:
-  ~GLContextFake() override {}
-};
-
 class GLApiTest : public testing::Test {
  public:
   void SetUp() override {
     fake_extension_string_ = "";
     fake_version_string_ = "";
     num_fake_extension_strings_ = 0;
     fake_extension_strings_ = nullptr;
 
-    DCHECK(!g_current_gl_context_tls);
-    g_current_gl_context_tls = new base::ThreadLocalPointer<GLApi>;
-
     SetGLGetProcAddressProc(
         static_cast<GLGetProcAddressProc>(&FakeGLGetProcAddress));
   }
 
   static GLFunctionPointerType GL_BINDING_CALL
   FakeGLGetProcAddress(const char* proc) {
     return reinterpret_cast<GLFunctionPointerType>(0x1);
   }
 
   void TearDown() override {
     api_.reset(nullptr);
-    delete g_current_gl_context_tls;
-    g_current_gl_context_tls = nullptr;
+    driver_.reset(nullptr);
 
     SetGLImplementation(kGLImplementationNone);
     fake_extension_string_ = "";
     fake_version_string_ = "";
     num_fake_extension_strings_ = 0;
     fake_extension_strings_ = nullptr;
   }
 
   void InitializeAPI(base::CommandLine* command_line) {
+    driver_.reset(new DriverGL());
+    driver_->fn.glGetStringFn = &FakeGetString;
+    driver_->fn.glGetStringiFn = &FakeGetStringi;
+    driver_->fn.glGetIntegervFn = &FakeGetIntegervFn;
+
     api_.reset(new RealGLApi());
-    g_current_gl_context_tls->Set(api_.get());
+    if (command_line)
+      api_->InitializeWithCommandLine(driver_.get(), command_line);
+    else
+      api_->Initialize(driver_.get());
 
-    g_driver_gl.ClearBindings();
-    g_driver_gl.fn.glGetStringFn = &FakeGetString;
-    g_driver_gl.fn.glGetStringiFn = &FakeGetStringi;
-    g_driver_gl.fn.glGetIntegervFn = &FakeGetIntegervFn;
-
-    fake_context_ = new GLContextFake();
-    if (command_line)
-      api_->InitializeWithCommandLine(&g_driver_gl, command_line);
-    else
-      api_->Initialize(&g_driver_gl);
     api_->InitializeFilteredExtensions();
-    g_driver_gl.InitializeCustomDynamicBindings(fake_context_.get());
+    std::unique_ptr<GLVersionInfo> version =
+        GetVersionInfoFromContext(api_.get());
+    driver_->InitializeDynamicBindings(
+        version.get(), GetGLExtensionsFromCurrentContext(api_.get()));
+    api_->set_version(std::move(version));
   }
 
   void SetFakeExtensionString(const char* fake_string) {
     SetGLImplementation(kGLImplementationDesktopGL);
     fake_extension_string_ = fake_string;
     fake_version_string_ = "2.1";
   }
 
   void SetFakeExtensionStrings(const char** fake_strings, uint32_t count) {
     SetGLImplementation(kGLImplementationDesktopGL);
@@ skipping 34 matching lines @@
                                                               index));
   }
 
  protected:
   static const char* fake_extension_string_;
   static const char* fake_version_string_;
 
   static uint32_t num_fake_extension_strings_;
   static const char** fake_extension_strings_;
 
-  scoped_refptr<GLContext> fake_context_;
   std::unique_ptr<DriverGL> driver_;
   std::unique_ptr<RealGLApi> api_;
 };
 
 const char* GLApiTest::fake_extension_string_ = "";
 const char* GLApiTest::fake_version_string_ = "";
 
 uint32_t GLApiTest::num_fake_extension_strings_ = 0;
 const char** GLApiTest::fake_extension_strings_ = nullptr;
 
@@ skipping 17 matching lines @@
 
 TEST_F(GLApiTest, DisabledExtensionBitTest) {
   static const char* kFakeExtensions[] = {
     "GL_ARB_timer_query"
   };
   static const char* kFakeDisabledExtensions = "GL_ARB_timer_query";
 
   SetFakeExtensionStrings(kFakeExtensions, arraysize(kFakeExtensions));
   InitializeAPI(nullptr);
 
-  EXPECT_TRUE(g_driver_gl.ext.b_GL_ARB_timer_query);
+  EXPECT_TRUE(driver_->ext.b_GL_ARB_timer_query);
 
   base::CommandLine command_line(base::CommandLine::NO_PROGRAM);
   command_line.AppendSwitchASCII(switches::kDisableGLExtensions,
                                  kFakeDisabledExtensions);
   InitializeAPI(&command_line);
 
-  EXPECT_FALSE(g_driver_gl.ext.b_GL_ARB_timer_query);
+  EXPECT_FALSE(driver_->ext.b_GL_ARB_timer_query);
 }
 
 TEST_F(GLApiTest, DisabledExtensionStringIndexTest) {
   static const char* kFakeExtensions[] = {
     "GL_EXT_1",
     "GL_EXT_2",
     "GL_EXT_3",
     "GL_EXT_4"
   };
   static const char* kFakeDisabledExtensions = "GL_EXT_1,GL_EXT_2,GL_FAKE";
@@ skipping 15 matching lines @@
                                  kFakeDisabledExtensions);
   InitializeAPI(&command_line);
 
   EXPECT_EQ(arraysize(kFilteredExtensions), GetNumExtensions());
   for (uint32_t i = 0; i < arraysize(kFilteredExtensions); ++i) {
     EXPECT_STREQ(kFilteredExtensions[i], GetExtensioni(i));
   }
 }
 
 }  // namespace gl