Issue 262963003: Output repaint rects for svg repaint tests

Issue 262963003: Output repaint rects for svg repaint tests (Closed)

Created:
6 years, 7 months ago by enne (OOO)

Modified:
6 years, 7 months ago

Reviewers:
ojan, abarth-chromium

CC:
blink-reviews, Stephen White

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Output repaint rects for svg repaint tests Previously all of these tests were converted to not output repaint rects and just output pixels. This ended up being a loss of information that was useful to detecting missing repaints, and so they should be turned back on where it makes sense. BUG=369609 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173666

Patch Set 1 #

Patch Set 2 : Now with less overflow #

Patch Set 3 : Make layer tree div also fixed pos #

Patch Set 4 : Relative, but hugely negative offset #

Patch Set 5 : Custom text output #

Patch Set 6 : Rebase #

Patch Set 7 : No expectations #

Patch Set 8 : With expectations, svg reftests #

Patch Set 9 : Fix up tests that don't want output rects #

Patch Set 10 : Remove changes to two tests #

Total comments: 1

Patch Set 11 : Rebase #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+172 lines, -4 lines)			Patch
M	LayoutTests/TestExpectations	View	1 2 3 4 5 6 7 8 9 10	1 chunk	+158 lines, -0 lines	0 comments	Download
M	LayoutTests/fast/repaint/resources/text-based-repaint.js	View	1 2 3 4 5 6 7 8	1 chunk	+0 lines, -1 line	0 comments	Download
M	LayoutTests/svg/as-image/set-img-height.html	View	1 2 3 4 5 6 7	1 chunk	+1 line, -0 lines	0 comments	Download
M	LayoutTests/svg/as-object/embedded-svg-size-changes.html	View	1 2 3 4 5 6 7 8	1 chunk	+1 line, -0 lines	0 comments	Download
M	LayoutTests/svg/as-object/nested-embedded-svg-size-changes.html	View	1 2 3 4 5 6 7 8	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/svg/custom/svg-image-resize.html	View	1 2 3 4 5 6 7	1 chunk	+1 line, -0 lines	0 comments	Download
M	LayoutTests/svg/custom/svg-percent-scale.html	View	1 2 3 4 5 6 7	1 chunk	+1 line, -0 lines	0 comments	Download
M	LayoutTests/svg/custom/svg-percent-scale-block.html	View	1 2 3 4 5 6 7	1 chunk	+1 line, -0 lines	0 comments	Download
M	LayoutTests/svg/custom/svg-percent-scale-vonly.html	View	1 2 3 4 5 6 7	1 chunk	+1 line, -0 lines	0 comments	Download
M	LayoutTests/svg/custom/use-elementInstance-methods.svg	View	1 2 3 4 5 6 7 8	1 chunk	+1 line, -0 lines	0 comments	Download
M	LayoutTests/svg/custom/use-event-handler-on-referenced-element.svg	View	1 2 3 4 5 6 7 8	1 chunk	+1 line, -0 lines	0 comments	Download
M	LayoutTests/svg/custom/use-event-handler-on-use-element.svg	View	1 2 3 4 5 6 7 8	1 chunk	+1 line, -0 lines	0 comments	Download
M	LayoutTests/svg/custom/use-instanceRoot-event-bubbling.xhtml	View	1 2 3 4 5 6 7 8	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/svg/custom/use-instanceRoot-event-listeners.xhtml	View	1 2 3 4 5 6 7 8	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/svg/dom/SVGPathSegList-xml-dom-synchronization.xhtml	View	1 2 3 4 5 6 7 8	1 chunk	+1 line, -0 lines	0 comments	Download
M	LayoutTests/svg/in-html/overflow-repaint.html	View	1 2 3 4 5 6 7	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

enne (OOO)

https://codereview.chromium.org/262963003/diff/160001/LayoutTests/svg/custom/use-instanceRoot-event-bubbling.xhtml File LayoutTests/svg/custom/use-instanceRoot-event-bubbling.xhtml (left): https://codereview.chromium.org/262963003/diff/160001/LayoutTests/svg/custom/use-instanceRoot-event-bubbling.xhtml#oldcode3 LayoutTests/svg/custom/use-instanceRoot-event-bubbling.xhtml:3: <script>window.enablePixelTesting = true;</script> This doesn't do anything if it's ...

6 years, 7 months ago (2014-05-07 20:02:38 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/262963003/180001

6 years, 7 months ago (2014-05-08 17:57:05 UTC) #4

Message was sent while issue was closed.

Change committed as 173666

Expand Messages | Collapse Messages