Issue 26296002: Move HostWindow.h from core/platform to platform in preparation for moving more parts of core/platf…

Issue 26296002: Move HostWindow.h from core/platform to platform in preparation for moving more parts of core/platf… (Closed)

Created:
7 years, 2 months ago by atreat

Modified:
7 years, 2 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink@master

Visibility:
Public.

Move HostWindow.h from core/platform to platform in preparation for moving more parts of core/platform/Widget*|Scroll* BUG=297477 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159042

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -79 lines)			Patch
M	Source/core/page/Chrome.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/page/ChromeClient.h	View		1 chunk	+1 line, -1 line	0 comments	Download
D	Source/core/platform/HostWindow.h	View		1 chunk	+0 lines, -71 lines	0 comments	Download
M	Source/core/platform/ScrollView.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/platform/Widget.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/platform/chromium/FramelessScrollViewClient.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/platform/chromium/PlatformScreenChromium.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	Source/platform/HostWindow.h	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	Source/platform/blink_platform.gypi	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/web/ValidationMessageClientImpl.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/web/WebPluginContainerImpl.cpp	View		2 chunks	+1 line, -1 line	0 comments	Download

Total messages: 10 (0 generated)

atreat

Moving HostWindow.h from Source/core/platform to Source/platform

7 years, 2 months ago (2013-10-07 17:25:36 UTC) #1

abarth-chromium

Should we move this code into Source/platform/widget ? It seems all related to the Widget ...

7 years, 2 months ago (2013-10-07 17:26:33 UTC) #2

abarth-chromium

Also, please add the h files to blink_platform.gypi.

7 years, 2 months ago (2013-10-07 17:27:26 UTC) #3

atreat

On 2013/10/07 17:27:26, abarth wrote: > Also, please add the h files to blink_platform.gypi. Done. ...

7 years, 2 months ago (2013-10-07 17:33:00 UTC) #4

kenneth.r.christiansen

Is this plan to get rid of Widget? It was created for Mac specific reasons

7 years, 2 months ago (2013-10-07 18:21:09 UTC) #5

atreat

On 2013/10/07 18:21:09, kenneth.r.christiansen wrote: > Is this plan to get rid of Widget? It ...

7 years, 2 months ago (2013-10-07 18:24:33 UTC) #6

abarth-chromium

On 2013/10/07 18:21:09, kenneth.r.christiansen wrote: > Is this plan to get rid of Widget? It ...

7 years, 2 months ago (2013-10-07 18:37:39 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adam.treat@samsung.com/26296002/2

7 years, 2 months ago (2013-10-07 18:38:31 UTC) #9

Message was sent while issue was closed.

Change committed as 159042