Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: ui/views/widget/native_widget_mac.mm

Issue 2629593005: MacViews: Support -[NSWindow close] on sheets. (Closed)
Patch Set: Fix lifetime Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/widget/native_widget_mac.mm
diff --git a/ui/views/widget/native_widget_mac.mm b/ui/views/widget/native_widget_mac.mm
index 1c6b46af73aa14cc9f57f8c992814b6d89d6e700..7da431fc0337d2b79b46c88c11906434db84fcd6 100644
--- a/ui/views/widget/native_widget_mac.mm
+++ b/ui/views/widget/native_widget_mac.mm
@@ -382,10 +382,6 @@ void NativeWidgetMac::CloseNow() {
if (!bridge_)
return;
- // Cocoa ignores -close calls on open sheets, so they should be closed
tapted 2017/01/13 19:36:53 I think when I wrote this things were structured a
- // asynchronously, using Widget::Close().
- DCHECK(!IsWindowModalSheet());
-
// NSWindows must be retained until -[NSWindow close] returns.
base::scoped_nsobject<NSWindow> window(GetNativeWindow(),
base::scoped_policy::RETAIN);

Powered by Google App Engine
This is Rietveld 408576698