third_party/WebKit/Source/modules/vibration/VibrationController.cpp - Issue 2629593004: Disambiguate LifecycleObserver::contextDestroyed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/vibration/VibrationController.cpp

Issue 2629593004: Disambiguate LifecycleObserver::contextDestroyed (Closed)

Patch Set: temp Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/vibration/VibrationController.h ('k') | third_party/WebKit/Source/modules/vr/VRController.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/vibration/VibrationController.cpp

diff --git a/third_party/WebKit/Source/modules/vibration/VibrationController.cpp b/third_party/WebKit/Source/modules/vibration/VibrationController.cpp

index ef07f8be7aea80e3defe7b813122a18cc08421c3..eaa3fb1e3de992cc265a53e0ab6cff17e89c84e6 100644

--- a/third_party/WebKit/Source/modules/vibration/VibrationController.cpp

+++ b/third_party/WebKit/Source/modules/vibration/VibrationController.cpp

@@ -171,13 +171,15 @@ void VibrationController::didCancel() {

m_timerDoVibrate.startOneShot(0, BLINK_FROM_HERE);

}

-void VibrationController::contextDestroyed() {

+void VibrationController::contextDestroyed(ExecutionContext*) {

cancel();

// If the document context was destroyed, never call the mojo service again.

m_service.reset();

}

+void VibrationController::contextDestroyed(Page*) {}

void VibrationController::pageVisibilityChanged() {

if (!page()->isPageVisible())

cancel();