third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h - Issue 2629593004: Disambiguate LifecycleObserver::contextDestroyed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h

Issue 2629593004: Disambiguate LifecycleObserver::contextDestroyed (Closed)

Patch Set: temp Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp ('k') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h

index c5da0e87b559864a7bad30795e61e6aeb2dc3117..abb65b3d6c0dfff596e7c4c3fe2487d2628fe431 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h

+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h

@@ -91,7 +91,7 @@ class ServiceWorkerRegistration final

void dispose();

// ContextLifecycleObserver overrides.

- void contextDestroyed() override;

+ void contextDestroyed(ExecutionContext*) override;

// A handle to the registration representation in the embedder.

std::unique_ptr<WebServiceWorkerRegistration::Handle> m_handle;