third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp - Issue 2629593004: Disambiguate LifecycleObserver::contextDestroyed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp

Issue 2629593004: Disambiguate LifecycleObserver::contextDestroyed (Closed)

Patch Set: temp Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.h ('k') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp

diff --git a/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp b/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp

index 4d4b53a78d44135ffd65dbb0d791f0dc1824af4f..89e1c58e317b50f251338a7073e2bf2919aab5fe 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp

+++ b/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp

@@ -207,8 +207,7 @@ RespondWithObserver* RespondWithObserver::create(

observer);

}

-void RespondWithObserver::contextDestroyed() {

- ContextLifecycleObserver::contextDestroyed();

+void RespondWithObserver::contextDestroyed(ExecutionContext*) {

if (m_observer) {

DCHECK_EQ(Pending, m_state);

m_observer.clear();