Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Unified Diff: third_party/WebKit/Source/modules/gamepad/NavigatorGamepad.h

Issue 2629593004: Disambiguate LifecycleObserver::contextDestroyed (Closed)
Patch Set: temp Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/gamepad/NavigatorGamepad.h
diff --git a/third_party/WebKit/Source/modules/gamepad/NavigatorGamepad.h b/third_party/WebKit/Source/modules/gamepad/NavigatorGamepad.h
index 226e8ed00c7c459b1e523a4398e0f74ea0f2c07d..7e7c95d4566387f1578936b781e9a0b9425d37af 100644
--- a/third_party/WebKit/Source/modules/gamepad/NavigatorGamepad.h
+++ b/third_party/WebKit/Source/modules/gamepad/NavigatorGamepad.h
@@ -74,15 +74,16 @@ class MODULES_EXPORT NavigatorGamepad final
void didRemoveGamepadEventListeners();
bool startUpdatingIfAttached();
- // ContextLifecycleObserver
- void contextDestroyed() override;
+ // ContextLifecycleObserver and PageVisibilityObserver
+ void contextDestroyed(ExecutionContext*) override;
+ void contextDestroyed(Page*) override;
+ void pageVisibilityChanged() override;
// PlatformEventController
void registerWithDispatcher() override;
void unregisterWithDispatcher() override;
bool hasLastData() override;
void didUpdateData() override;
- void pageVisibilityChanged() override;
// LocalDOMWindow::EventListenerObserver
void didAddEventListener(LocalDOMWindow*, const AtomicString&) override;

Powered by Google App Engine
This is Rietveld 408576698