Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1499)

Unified Diff: third_party/WebKit/Source/core/workers/WorkerThreadTest.cpp

Issue 2629593004: Disambiguate LifecycleObserver::contextDestroyed (Closed)
Patch Set: temp Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/workers/WorkerThreadTest.cpp
diff --git a/third_party/WebKit/Source/core/workers/WorkerThreadTest.cpp b/third_party/WebKit/Source/core/workers/WorkerThreadTest.cpp
index 1cffd5c367c23c44f519682d0dcd645739e4a5c2..130c1f42e2799992019b72ec26f484b236515cd8 100644
--- a/third_party/WebKit/Source/core/workers/WorkerThreadTest.cpp
+++ b/third_party/WebKit/Source/core/workers/WorkerThreadTest.cpp
@@ -87,7 +87,7 @@ class WorkerThreadTest : public ::testing::Test {
EXPECT_CALL(*m_reportingProxy, countFeature(_)).Times(AnyNumber());
EXPECT_CALL(*m_reportingProxy, willDestroyWorkerGlobalScope()).Times(1);
EXPECT_CALL(*m_reportingProxy, didTerminateWorkerThread()).Times(1);
- EXPECT_CALL(*m_lifecycleObserver, contextDestroyed()).Times(1);
+ EXPECT_CALL(*m_lifecycleObserver, contextDestroyed(_)).Times(1);
}
void expectReportingCallsForWorkerPossiblyTerminatedBeforeInitialization() {
@@ -101,7 +101,7 @@ class WorkerThreadTest : public ::testing::Test {
EXPECT_CALL(*m_reportingProxy, willDestroyWorkerGlobalScope())
.Times(AtMost(1));
EXPECT_CALL(*m_reportingProxy, didTerminateWorkerThread()).Times(1);
- EXPECT_CALL(*m_lifecycleObserver, contextDestroyed()).Times(1);
+ EXPECT_CALL(*m_lifecycleObserver, contextDestroyed(_)).Times(1);
}
void expectReportingCallsForWorkerForciblyTerminated() {
@@ -112,7 +112,7 @@ class WorkerThreadTest : public ::testing::Test {
EXPECT_CALL(*m_reportingProxy, didEvaluateWorkerScript(false)).Times(1);
EXPECT_CALL(*m_reportingProxy, willDestroyWorkerGlobalScope()).Times(1);
EXPECT_CALL(*m_reportingProxy, didTerminateWorkerThread()).Times(1);
- EXPECT_CALL(*m_lifecycleObserver, contextDestroyed()).Times(1);
+ EXPECT_CALL(*m_lifecycleObserver, contextDestroyed(_)).Times(1);
}
ExitCode getExitCode() { return m_workerThread->getExitCodeForTesting(); }
@@ -264,7 +264,7 @@ TEST_F(WorkerThreadTest, Terminate_WhileDebuggerTaskIsRunningOnInitialization) {
EXPECT_CALL(*m_reportingProxy, willDestroyWorkerGlobalScope()).Times(1);
EXPECT_CALL(*m_reportingProxy, countFeature(_)).Times(AnyNumber());
EXPECT_CALL(*m_reportingProxy, didTerminateWorkerThread()).Times(1);
- EXPECT_CALL(*m_lifecycleObserver, contextDestroyed()).Times(1);
+ EXPECT_CALL(*m_lifecycleObserver, contextDestroyed(_)).Times(1);
std::unique_ptr<Vector<CSPHeaderAndType>> headers =
WTF::makeUnique<Vector<CSPHeaderAndType>>();

Powered by Google App Engine
This is Rietveld 408576698