third_party/WebKit/Source/core/loader/PrerenderHandle.cpp - Issue 2629593004: Disambiguate LifecycleObserver::contextDestroyed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/PrerenderHandle.cpp

Issue 2629593004: Disambiguate LifecycleObserver::contextDestroyed (Closed)

Patch Set: temp Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/loader/PrerenderHandle.cpp

diff --git a/third_party/WebKit/Source/core/loader/PrerenderHandle.cpp b/third_party/WebKit/Source/core/loader/PrerenderHandle.cpp

index 1c6458d3214d2b394e5083d63d822021ebc527f5..bf8f60877ea0297d1f12dd66ab497886558a19a8 100644

--- a/third_party/WebKit/Source/core/loader/PrerenderHandle.cpp

+++ b/third_party/WebKit/Source/core/loader/PrerenderHandle.cpp

@@ -89,7 +89,7 @@ const KURL& PrerenderHandle::url() const {

return m_prerender->url();

}

-void PrerenderHandle::contextDestroyed() {

+void PrerenderHandle::contextDestroyed(ExecutionContext*) {

// A PrerenderHandle is not removed from LifecycleNotifier::m_observers until

// the next GC runs. Thus contextDestroyed() can be called for a

// PrerenderHandle that is already cancelled (and thus detached). In that