third_party/WebKit/Source/core/dom/MessagePort.h - Issue 2629593004: Disambiguate LifecycleObserver::contextDestroyed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/MessagePort.h

Issue 2629593004: Disambiguate LifecycleObserver::contextDestroyed (Closed)

Patch Set: temp Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/MessagePort.h

diff --git a/third_party/WebKit/Source/core/dom/MessagePort.h b/third_party/WebKit/Source/core/dom/MessagePort.h

index da26cba1ddcc2959ddfc6457b76aab76f7ce1ddd..43dfa0d9a9801cf3083afcf5605a2dc6cd01aec6 100644

--- a/third_party/WebKit/Source/core/dom/MessagePort.h

+++ b/third_party/WebKit/Source/core/dom/MessagePort.h

@@ -105,7 +105,7 @@ class CORE_EXPORT MessagePort : public EventTargetWithInlineData,

bool hasPendingActivity() const final;

// ContextLifecycleObserver implementation.

- void contextDestroyed() override { close(); }

+ void contextDestroyed(ExecutionContext*) override { close(); }

void setOnmessage(EventListener* listener) {

setAttributeEventListener(EventTypeNames::message, listener);