Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Side by Side Diff: third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp

Issue 2629593004: Disambiguate LifecycleObserver::contextDestroyed (Closed)
Patch Set: temp Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2006, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2004, 2006, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2005-2007 Alexey Proskuryakov <ap@webkit.org> 3 * Copyright (C) 2005-2007 Alexey Proskuryakov <ap@webkit.org>
4 * Copyright (C) 2007, 2008 Julien Chaffraix <jchaffraix@webkit.org> 4 * Copyright (C) 2007, 2008 Julien Chaffraix <jchaffraix@webkit.org>
5 * Copyright (C) 2008, 2011 Google Inc. All rights reserved. 5 * Copyright (C) 2008, 2011 Google Inc. All rights reserved.
6 * Copyright (C) 2012 Intel Corporation 6 * Copyright (C) 2012 Intel Corporation
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Lesser General Public 9 * modify it under the terms of the GNU Lesser General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 1783 matching lines...) Expand 10 before | Expand all | Expand 10 after
1794 } 1794 }
1795 1795
1796 void XMLHttpRequest::suspend() { 1796 void XMLHttpRequest::suspend() {
1797 m_progressEventThrottle->suspend(); 1797 m_progressEventThrottle->suspend();
1798 } 1798 }
1799 1799
1800 void XMLHttpRequest::resume() { 1800 void XMLHttpRequest::resume() {
1801 m_progressEventThrottle->resume(); 1801 m_progressEventThrottle->resume();
1802 } 1802 }
1803 1803
1804 void XMLHttpRequest::contextDestroyed() { 1804 void XMLHttpRequest::contextDestroyed(ExecutionContext*) {
1805 InspectorInstrumentation::didFailXHRLoading(getExecutionContext(), this, this, 1805 InspectorInstrumentation::didFailXHRLoading(getExecutionContext(), this, this,
1806 m_method, m_url); 1806 m_method, m_url);
1807 m_progressEventThrottle->stop(); 1807 m_progressEventThrottle->stop();
1808 internalAbort(); 1808 internalAbort();
1809 } 1809 }
1810 1810
1811 bool XMLHttpRequest::hasPendingActivity() const { 1811 bool XMLHttpRequest::hasPendingActivity() const {
1812 // Neither this object nor the JavaScript wrapper should be deleted while 1812 // Neither this object nor the JavaScript wrapper should be deleted while
1813 // a request is in progress because we need to keep the listeners alive, 1813 // a request is in progress because we need to keep the listeners alive,
1814 // and they are referenced by the JavaScript wrapper. 1814 // and they are referenced by the JavaScript wrapper.
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
1847 visitor->traceWrappers(m_responseDocument); 1847 visitor->traceWrappers(m_responseDocument);
1848 visitor->traceWrappers(m_responseArrayBuffer); 1848 visitor->traceWrappers(m_responseArrayBuffer);
1849 XMLHttpRequestEventTarget::traceWrappers(visitor); 1849 XMLHttpRequestEventTarget::traceWrappers(visitor);
1850 } 1850 }
1851 1851
1852 std::ostream& operator<<(std::ostream& ostream, const XMLHttpRequest* xhr) { 1852 std::ostream& operator<<(std::ostream& ostream, const XMLHttpRequest* xhr) {
1853 return ostream << "XMLHttpRequest " << static_cast<const void*>(xhr); 1853 return ostream << "XMLHttpRequest " << static_cast<const void*>(xhr);
1854 } 1854 }
1855 1855
1856 } // namespace blink 1856 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698