Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(808)

Unified Diff: remoting/base/chromoting_event.h

Issue 2629593003: [Chromoting.com] Make Android telemetry report host version/os/os version (Closed)
Patch Set: PTAL Point Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/base/chromoting_event.h
diff --git a/remoting/base/chromoting_event.h b/remoting/base/chromoting_event.h
index 3e7a9591b8512d0e4ab48c42576656a52d4b71c0..40b8d46ed5e57ff7b5d7be50d8be1b7f2597b42b 100644
--- a/remoting/base/chromoting_event.h
+++ b/remoting/base/chromoting_event.h
@@ -92,6 +92,9 @@ class ChromotingEvent {
static const char kCpuKey[];
static const char kDecodeLatencyKey[];
static const char kEncodeLatencyKey[];
+ static const char kHostOsKey[];
+ static const char kHostOsVersionKey[];
+ static const char kHostVersionKey[];
static const char kMaxCaptureLatencyKey[];
static const char kMaxDecodeLatencyKey[];
static const char kMaxEncodeLatencyKey[];
@@ -142,6 +145,9 @@ class ChromotingEvent {
// Returns true if the SessionState concludes the end of session.
static bool IsEndOfSession(SessionState state);
+ // Converts the OS type String into the enum value.
+ static Os toOs(const std::string& os);
Sergey Ulanov 2017/01/13 00:23:17 Maybe call it ParseOsFromString() or something lik
Yuwei 2017/01/13 01:51:12 Done.
+
private:
std::unique_ptr<base::DictionaryValue> values_map_;

Powered by Google App Engine
This is Rietveld 408576698