Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: remoting/base/chromoting_event.cc

Issue 2629593003: [Chromoting.com] Make Android telemetry report host version/os/os version (Closed)
Patch Set: PTAL Point Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/base/chromoting_event.cc
diff --git a/remoting/base/chromoting_event.cc b/remoting/base/chromoting_event.cc
index 51f725d9bf5836a095779d1244652ee01a8d8554..b5c2b830d5f365e9c885c45cb9c88adf1989f752 100644
--- a/remoting/base/chromoting_event.cc
+++ b/remoting/base/chromoting_event.cc
@@ -4,6 +4,7 @@
#include "remoting/base/chromoting_event.h"
+#include "base/strings/string_util.h"
#include "base/strings/stringize_macros.h"
#include "base/sys_info.h"
@@ -14,6 +15,9 @@ const char ChromotingEvent::kConnectionErrorKey[] = "connection_error";
const char ChromotingEvent::kCpuKey[] = "cpu";
const char ChromotingEvent::kDecodeLatencyKey[] = "decode_latency";
const char ChromotingEvent::kEncodeLatencyKey[] = "encode_latency";
+const char ChromotingEvent::kHostOsKey[] = "host_os";
+const char ChromotingEvent::kHostOsVersionKey[] = "host_os_version";
+const char ChromotingEvent::kHostVersionKey[] = "host_version";
const char ChromotingEvent::kMaxCaptureLatencyKey[] = "max_capture_latency";
const char ChromotingEvent::kMaxDecodeLatencyKey[] = "max_decode_latency";
const char ChromotingEvent::kMaxEncodeLatencyKey[] = "max_encode_latency";
@@ -120,4 +124,23 @@ bool ChromotingEvent::IsEndOfSession(SessionState state) {
state == SessionState::CONNECTION_CANCELED;
}
+// static
+ChromotingEvent::Os ChromotingEvent::toOs(const std::string& os) {
+ std::string lowerOs = base::ToLowerASCII(os);
Sergey Ulanov 2017/01/13 00:23:17 lower_os
Yuwei 2017/01/13 01:51:12 Done.
+ if (lowerOs == "linux") {
+ return Os::CHROMOTING_LINUX;
+ } else if (lowerOs == "chromeos") {
+ return Os::CHROMOTING_CHROMEOS;
+ } else if (lowerOs == "mac") {
+ return Os::CHROMOTING_MAC;
+ } else if (lowerOs == "windows") {
+ return Os::CHROMOTING_WINDOWS;
+ } else if (lowerOs == "android") {
+ return Os::CHROMOTING_ANDROID;
+ } else if (lowerOs == "ios") {
+ return Os::CHROMOTING_IOS;
+ }
+ return Os::OTHER;
+}
+
} // namespace remoting

Powered by Google App Engine
This is Rietveld 408576698