components/webapks_ui/resources/about_webapks.html - Issue 2629573004: Add a chrome://webapks page.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/webapks_ui/resources/about_webapks.html

Issue 2629573004: Add a chrome://webapks page. (Closed)

Patch Set: Add a chrome://webapks page. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/webapks_ui/resources/about_webapks.css ('K') | « components/webapks_ui/resources/about_webapks.css ('k') | components/webapks_ui/resources/about_webapks.js » ('j') | components/webapks_ui/resources/about_webapks.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!doctype html>

	2

	3 <!--

	4 about:webapks template page

	5 -->

	6

	7 <html id="t" i18n-values="dir:textdirection;lang:language">
	Dan Beam 2017/01/24 18:41:50 where are you copying this from? can we do <html where are you copying this from? can we do <html dir="$i18n{textdirection}" lang="$i18n{language}"> instead? does $i18n{} substitution run on your page? gonzalon 2017/01/24 20:43:29 I think I based this from https://cs.chromium.org/ Show quoted text On 2017/01/24 18:41:50, Dan Beam wrote: > where are you copying this from? > > can we do > > <html dir="$i18n{textdirection}" lang="$i18n{language}"> > > instead? does $i18n{} substitution run on your page? I think I based this from https://cs.chromium.org/chromium/src/components/flags_ui/resources/flags.html... I was going to i18n at first, but I was then told it's better not to, forgot to remove the i18n references.
	8 <head>

	9 <meta charset="utf-8">

	10 <meta name="viewport" content="width=device-width">

	11 <title>About WebAPKs</title>
	Dan Beam 2017/01/24 18:41:50 why are you varying direction and language if you' why are you varying direction and language if you're embedding an LTR/English string here? gonzalon 2017/01/24 20:43:29 I was going to i18n at first, but I was then told Show quoted text On 2017/01/24 18:41:50, Dan Beam wrote: > why are you varying direction and language if you're embedding an LTR/English > string here? I was going to i18n at first, but I was then told it's better not to, forgot to remove the i18n references.
	12 <link rel="stylesheet" href="chrome://resources/css/text_defaults.css">

	13 <link rel="stylesheet" href="chrome://webapks/about_webapks.css">

	14

	15 <script src="chrome://resources/js/cr.js"></script>

	16 <script src="chrome://resources/js/load_time_data.js"></script>

	17 <script src="chrome://resources/js/parse_html_subset.js"></script>

	18 <script src="chrome://resources/js/util.js"></script>

	19 <script src="chrome://webapks/webapks.js"></script>

	20 <script src="chrome://webapks/strings.js"></script>

	21 </head>

	22

	23 <body>

	24 <div id="outer">

	25 <div id="logo">

	26 <img src="../../../components/resources/default_100_percent/%DISTRIBUTIO N%/product_logo.png">

	27 </div>

	28

	29 <br><br>
	Dan Beam 2017/01/24 18:41:50 you should not need <br> tags, you can likely just you should not need <br> tags, you can likely just add more margin-bottom on #logo gonzalon 2017/01/24 20:43:29 Done. Show quoted text On 2017/01/24 18:41:50, Dan Beam wrote: > you should not need <br> tags, you can likely just add more margin-bottom on > #logo Done.
	30 <div>

	31 <span class="label">WebAPKs:</span>

	32 </div>

	33

	34 <div class="content" id="webapks-list"></div>

	35 </div>

	36 </body>

	37 </html>

OLD	NEW