chrome/browser/android/webapk/webapk_info.cc - Issue 2629573004: Add a chrome://webapks page.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/android/webapk/webapk_info.cc

Issue 2629573004: Add a chrome://webapks page. (Closed)

Patch Set: Adds an about:webapks page with information about all installed Web APKs on the device Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright (c) 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "chrome/browser/android/webapk/webapk_info.h"

	6

	7 WebApkInfo::WebApkInfo(const std::string short_name,
	pkotwicz 2017/01/20 16:57:17 This should be: const std::string& short_name, Pa This should be: const std::string& short_name, Passing the parameter as a reference avoids a copy gonzalon 2017/01/20 19:27:01 Done. Show quoted text On 2017/01/20 16:57:17, pkotwicz wrote: > This should be: > const std::string& short_name, > > Passing the parameter as a reference avoids a copy Done.
	8 const std::string package_name,
	pkotwicz 2017/01/20 16:57:17 This should be: const std::string& package_name, This should be: const std::string& package_name, gonzalon 2017/01/20 19:27:01 Done. Show quoted text On 2017/01/20 16:57:17, pkotwicz wrote: > This should be: > const std::string& package_name, Done.
	9 const int shell_apk_version,
	pkotwicz 2017/01/20 16:57:17 This does not need to be const. Passing ints by co This does not need to be const. Passing ints by copy is fine gonzalon 2017/01/20 19:27:01 Done. Show quoted text On 2017/01/20 16:57:17, pkotwicz wrote: > This does not need to be const. Passing ints by copy is fine Done.
	10 const int version_code)
	pkotwicz 2017/01/20 16:57:17 This does not need to be const. This does not need to be const. gonzalon 2017/01/20 19:27:01 Done. Show quoted text On 2017/01/20 16:57:17, pkotwicz wrote: > This does not need to be const. Done.
	11 : short_name(short_name),

	12 package_name(package_name),

	13 shell_apk_version(shell_apk_version),

	14 version_code(version_code) {}

	15

	16 WebApkInfo::~WebApkInfo() {}

OLD	NEW

« no previous file with comments | « chrome/browser/android/webapk/webapk_info.h ('k') | chrome/browser/ui/BUILD.gn » ('j') | chrome/browser/ui/webui/webapks_handler.h » ('J')