components/webapks_ui/webapks_ui_constants.cc - Issue 2629573004: Add a chrome://webapks page.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/webapks_ui/webapks_ui_constants.cc

Issue 2629573004: Add a chrome://webapks page. (Closed)

Patch Set: Removes strings from i18n file Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "components/webapks_ui/webapks_ui_constants.h"

	6

	7 namespace webapks_ui {

	8

	9 // Resource paths.

	10 const char kAboutWebApksCSS[] = "about_webapks.css";

	11 const char kWebApksJS[] = "webapks.js";
	pkotwicz 2017/01/19 19:37:18 I think that these constants can be put in the ano I think that these constants can be put in the anonymous namespace in chrome/browser/ui/webui/webapks_ui.cc (Though you can inline these constants too) gonzalon 2017/01/19 23:50:17 Done. Show quoted text On 2017/01/19 19:37:18, pkotwicz wrote: > I think that these constants can be put in the anonymous namespace in > chrome/browser/ui/webui/webapks_ui.cc (Though you can inline these constants > too) Done.
	12

	13 // Message handlers.

	14 const char kRequestWebApksInfo[] = "requestWebApksInfo";
	pkotwicz 2017/01/19 19:37:18 I think that this constant can be inlined. e.g. ht I think that this constant can be inlined. e.g. https://cs.chromium.org/chromium/src/content/browser/gpu/gpu_internals_ui.cc?... gonzalon 2017/01/19 23:50:17 Done. Show quoted text On 2017/01/19 19:37:18, pkotwicz wrote: > I think that this constant can be inlined. e.g. > https://cs.chromium.org/chromium/src/content/browser/gpu/gpu_internals_ui.cc?... Done.
	15 const char kReturnWebApksInfo[] = "returnWebApksInfo";
	pkotwicz 2017/01/19 19:37:18 I think that this constant can be inlined. e.g. ht I think that this constant can be inlined. e.g. https://cs.chromium.org/chromium/src/content/browser/gpu/gpu_internals_ui.cc?... gonzalon 2017/01/19 23:50:17 Done. Show quoted text On 2017/01/19 19:37:18, pkotwicz wrote: > I think that this constant can be inlined. e.g. > https://cs.chromium.org/chromium/src/content/browser/gpu/gpu_internals_ui.cc?... Done.
	16

	17 } // namespace webapks_ui

OLD	NEW

« components/webapks_ui/resources/about_webapks.js ('K') | « components/webapks_ui/webapks_ui_constants.h ('k') | no next file » | no next file with comments »