components/resources/webapks_ui_resources.grdp - Issue 2629573004: Add a chrome://webapks page.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/resources/webapks_ui_resources.grdp

Issue 2629573004: Add a chrome://webapks page. (Closed)

Patch Set: Removes strings from i18n file Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <grit-part>

	3 <include name="IDR_WEBAPKS_UI_CSS" file="../webapks_ui/resources/about_webapks .css" type="BINDATA" />
	pkotwicz 2017/01/19 19:37:18 I think you need compress="gzip" as well. You can I think you need compress="gzip" as well. You can double check with Andrew. He's the expert. https://codereview.chromium.org/1968993002 gonzalon 2017/01/19 23:50:17 Done. Show quoted text On 2017/01/19 19:37:18, pkotwicz wrote: > I think you need compress="gzip" as well. > > You can double check with Andrew. He's the expert. > https://codereview.chromium.org/1968993002 Done.
	4 <include name="IDR_WEBAPKS_UI_HTML" file="../webapks_ui/resources/about_webapk s.html" flattenhtml="true" allowexternalscript="true" type="BINDATA" />

	5 <include name="IDR_WEBAPKS_UI_JS" file="../webapks_ui/resources/about_webapks. js" type="BINDATA" />

	6 </grit-part>

OLD	NEW