Issue 2629533002: Fix leak of message snapshot buffer when attempting to send an illegal object.

Issue 2629533002: Fix leak of message snapshot buffer when attempting to send an illegal object. (Closed)

Created:
3 years, 11 months ago by rmacnak

Modified:
3 years, 11 months ago

Reviewers:
Florian Schneider, siva

CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Fix leak of message snapshot buffer when attempting to send an illegal object. Fix leak with FLAG_enable_debug_break. R=asiva@google.com, fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/2ec03cba702638cc7217edf46d1c35e7f19c944c

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+120 lines, -51 lines)			Patch
M	runtime/lib/isolate.cc	View	3 chunks	+10 lines, -3 lines	0 comments	Download
M	runtime/lib/vmservice.cc	View	2 chunks	+8 lines, -2 lines	0 comments	Download
M	runtime/vm/benchmark_test.cc	View	6 chunks	+12 lines, -4 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	2 chunks	+9 lines, -2 lines	0 comments	Download
M	runtime/vm/dart_api_message.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/datastream.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/isolate.cc	View	3 chunks	+11 lines, -4 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/service_isolate.cc	View	6 chunks	+13 lines, -6 lines	0 comments	Download
M	runtime/vm/snapshot.h	View	4 chunks	+15 lines, -3 lines	0 comments	Download
M	runtime/vm/snapshot.cc	View	4 chunks	+6 lines, -1 line	0 comments	Download
M	runtime/vm/snapshot_test.cc	View	27 chunks	+33 lines, -24 lines	0 comments	Download

Total messages: 9 (4 generated)

rmacnak

3 years, 11 months ago (2017-01-12 00:50:10 UTC) #9

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2ec03cba702638cc7217edf46d1c35e7f19c944c (presubmit successful).