test/cctest/wasm/test-run-wasm-module.cc - Issue 2629523007: [wasm] JS-API: enable WebAssembly.instantiate tests; fix LinkError

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/wasm/test-run-wasm-module.cc

Issue 2629523007: [wasm] JS-API: enable WebAssembly.instantiate tests; fix LinkError (Closed)

Patch Set: moved import validation Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: test/cctest/wasm/test-run-wasm-module.cc

diff --git a/test/cctest/wasm/test-run-wasm-module.cc b/test/cctest/wasm/test-run-wasm-module.cc

index 54f851bab5da914f004063287dced3d9352e3d51..4938408a1d924d39651eaff946e1f75016c87225 100644

--- a/test/cctest/wasm/test-run-wasm-module.cc

+++ b/test/cctest/wasm/test-run-wasm-module.cc

@@ -240,8 +240,8 @@ class WasmSerializationTest {

ErrorThrower thrower(current_isolate(), "");

v8::Local<v8::WasmCompiledModule> deserialized_module;

CHECK(Deserialize().ToLocal(&deserialized_module));

- Handle<JSObject> module_object =

- Handle<JSObject>::cast(v8::Utils::OpenHandle(*deserialized_module));

+ Handle<WasmModuleObject> module_object = Handle<WasmModuleObject>::cast(

+ v8::Utils::OpenHandle(*deserialized_module));

{

DisallowHeapAllocation assume_no_gc;

Handle<WasmCompiledModule> compiled_part(