Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Unified Diff: third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp

Issue 2629433003: ShapeDetection: use mojom::Bitmap for mojo interface. (Closed)
Patch Set: ShapeDetection: use mojom::Bitmap for mojo interface. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp
diff --git a/third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp b/third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp
index 9139cde779d5a8a08a417a3ca681ba29fee03647..e976c863d4ee4338c5f01e946da96e09d873f672 100644
--- a/third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp
+++ b/third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp
@@ -23,11 +23,8 @@ TextDetector::TextDetector(LocalFrame& frame) : ShapeDetector(frame) {
&TextDetector::onTextServiceConnectionError, wrapWeakPersistent(this))));
}
-ScriptPromise TextDetector::doDetect(
- ScriptPromiseResolver* resolver,
- mojo::ScopedSharedBufferHandle sharedBufferHandle,
- int imageWidth,
- int imageHeight) {
+ScriptPromise TextDetector::doDetect(ScriptPromiseResolver* resolver,
+ skia::mojom::blink::BitmapPtr bitmap) {
ScriptPromise promise = resolver->promise();
if (!m_textService) {
resolver->reject(DOMException::create(
@@ -35,7 +32,7 @@ ScriptPromise TextDetector::doDetect(
return promise;
}
m_textServiceRequests.add(resolver);
- m_textService->Detect(std::move(sharedBufferHandle), imageWidth, imageHeight,
+ m_textService->Detect(std::move(bitmap),
convertToBaseCallback(WTF::bind(
&TextDetector::onDetectText, wrapPersistent(this),
wrapPersistent(resolver))));

Powered by Google App Engine
This is Rietveld 408576698