ShapeDetection: use mojom::Bitmap for mojo interface.

chrome/android/java/src/org/chromium/chrome/browser/shapedetection/BarcodeDetectionImpl.java

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.shapedetection;
 
 import android.content.Context;
 import android.graphics.Bitmap;
+import android.graphics.Bitmap.Config;
 import android.graphics.Point;
 import android.graphics.Rect;
 import android.util.SparseArray;
 
 import com.google.android.gms.vision.Frame;
 import com.google.android.gms.vision.barcode.Barcode;
 import com.google.android.gms.vision.barcode.BarcodeDetector;
 
 import org.chromium.base.Log;
 import org.chromium.chrome.browser.externalauth.ExternalAuthUtils;
 import org.chromium.chrome.browser.externalauth.UserRecoverableErrorHandler;
 import org.chromium.gfx.mojom.PointF;
 import org.chromium.gfx.mojom.RectF;
 import org.chromium.mojo.system.MojoException;
-import org.chromium.mojo.system.SharedBufferHandle;
-import org.chromium.mojo.system.SharedBufferHandle.MapFlags;
 import org.chromium.shape_detection.mojom.BarcodeDetection;
 import org.chromium.shape_detection.mojom.BarcodeDetectionResult;
+import org.chromium.skia.mojom.ColorType;
 
 import java.nio.ByteBuffer;
 
 /**
  * Implementation of mojo BarcodeDetection, using Google Play Services vision package.
  */
 public class BarcodeDetectionImpl implements BarcodeDetection {
     private static final String TAG = "BarcodeDetectionImpl";
 
     private final Context mContext;
     private BarcodeDetector mBarcodeDetector;
+    private Config mBitmapConfig;
 
     public BarcodeDetectionImpl(Context context) {
         mContext = context;
         mBarcodeDetector = new BarcodeDetector.Builder(mContext).build();
     }
 
+    private boolean validConfig(int colorType) {
+        switch (colorType) {
+            case ColorType.ALPHA_8:
+                mBitmapConfig = Config.ALPHA_8;
+                return true;
+            case ColorType.RGB_565:
+                mBitmapConfig = Config.RGB_565;
+                return true;
+            case ColorType.ARGB_4444:
+                mBitmapConfig = Config.ARGB_4444;
+                return true;
+            case ColorType.RGBA_8888:
+                mBitmapConfig = Config.ARGB_8888;
+                return true;
+        }
+        return false;
+    }
+
     @Override
-    public void detect(
-            SharedBufferHandle frameData, int width, int height, DetectResponse callback) {
+    public void detect(org.chromium.skia.mojom.Bitmap bitmapData, DetectResponse callback) {
         if (!ExternalAuthUtils.getInstance().canUseGooglePlayServices(
                     mContext, new UserRecoverableErrorHandler.Silent())) {
             Log.e(TAG, "Google Play Services not available");
             callback.call(new BarcodeDetectionResult[0]);
             return;
         }
         // The vision library will be downloaded the first time the API is used
         // on the device; this happens "fast", but it might have not completed,
         // bail in this case. Also, the API was disabled between and v.9.0 and
         // v.9.2, see https://developers.google.com/android/guides/releases.
         if (!mBarcodeDetector.isOperational()) {
             Log.e(TAG, "BarcodeDetector is not operational");
             callback.call(new BarcodeDetectionResult[0]);
             return;
         }
 
+        int width = bitmapData.width;
+        int height = bitmapData.height;
         final long numPixels = (long) width * height;
         // TODO(mcasas): https://crbug.com/670028 homogeneize overflow checking.
-        if (!frameData.isValid() || width <= 0 || height <= 0 || numPixels > (Long.MAX_VALUE / 4)) {
+        if (bitmapData.pixelData == null || width <= 0 || height <= 0
+                || numPixels > (Long.MAX_VALUE / 4) || !validConfig(bitmapData.colorType)) {

[mcasas, 2017/01/24 00:52:05]

I doubt that any detector (this or TextDetectionImpl) 
would work with anything but 32bpp variations (the 
8888 ones).  Also, Blink sends one of two formats:
BGRA_8888/RGBA_8888 but I don't see those two
being handled or a note as to why that isn't the case.

[junwei, 2017/01/25 06:14:50]

I updated l.57 to handle BGRA_8888 the same as RGBA_8888, because it will be
converted kN32_SkColorType with [1] when creating bitmap.

[1]
http://androidxref.com/7.1.1_r6/xref/frameworks/base/core/jni/android/graphic...

             callback.call(new BarcodeDetectionResult[0]);
             return;
         }
 
         // Mapping |frameData| will fail if the intended mapped size is larger
         // than its actual capacity, which is limited by the appropriate
         // mojo::edk::Configuration entry.
-        ByteBuffer imageBuffer = frameData.map(0, numPixels * 4, MapFlags.none());
+        ByteBuffer imageBuffer = ByteBuffer.wrap(bitmapData.pixelData);
         if (imageBuffer.capacity() <= 0) {
             callback.call(new BarcodeDetectionResult[0]);
             return;
         }
 
-        Bitmap bitmap = Bitmap.createBitmap(width, height, Bitmap.Config.ARGB_8888);
+        Bitmap bitmap = Bitmap.createBitmap(width, height, mBitmapConfig);
         bitmap.copyPixelsFromBuffer(imageBuffer);
 
         Frame frame = null;
         try {
             // This constructor implies a pixel format conversion to YUV.
             frame = new Frame.Builder().setBitmap(bitmap).build();
         } catch (IllegalArgumentException | IllegalStateException ex) {
             Log.e(TAG, "Frame.Builder().setBitmap() or build(): " + ex);
             callback.call(new BarcodeDetectionResult[0]);
             return;
@@ skipping 27 matching lines @@
     public void close() {
         mBarcodeDetector.release();
     }
 
     @Override
     public void onConnectionError(MojoException e) {
         close();
     }
 
 }