Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 262943002: Roll gyp r1895:1911 (Closed)

Created:
6 years, 7 months ago by Torne
Modified:
6 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews, Daniel Bratell
Visibility:
Public.

Description

Roll gyp r1895:1911 This includes r1911, the revert of r1896 which increased ios build flakiness. r1911 Revert "gyp: use all processors instead of hard-coded 8." r1910 android: only emit multilib variables for target builds. r1909 gyp: Optimize IsStrCanonicalNumber for common case r1908 1-5% faster gyp: Use a simpler deepcopy. r1907 Test handling of empty RULE_INPUT_DIRNAME and fix this on android. r1906 gyp performance: Another fixed O(n^2) in dependency calcs. r1905 gyp: isinstance -> type for another 1-5% save. r1904 gyp: avoid copying items that will be deleted. r1903 Show ASM output file instead of input file, just like CC and CXX. r1902 win: disable two flaky tests on gyp-win32 r1901 Remove the default setting for clcompile_cmd in msvs-ninja r1900 gyp: cache conditional ASTs for 3 CPU seconds (5%) gain. r1899 gyp: use a set() in DeepDependencies for less O(n^2). r1898 gyp: fix O(n^2) in dependency calculations. r1897 gyp: 1% faster by optimizing IsPathSections r1896 gyp: use all processors instead of hard-coded 8. TBR=thakis@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268110

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Torne
Hi Nico, I'm not gonna TBR this, or land it right now (the tree is ...
6 years, 7 months ago (2014-05-02 12:46:41 UTC) #1
Torne
Doh, of course LKGR hasn't caught up to the revert yet so the patch doesn't ...
6 years, 7 months ago (2014-05-02 12:47:21 UTC) #2
Torne
The CQ bit was checked by torne@chromium.org
6 years, 7 months ago (2014-05-04 12:52:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/torne@chromium.org/262943002/1
6 years, 7 months ago (2014-05-04 12:52:56 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-04 16:34:04 UTC) #5
Message was sent while issue was closed.
Change committed as 268110

Powered by Google App Engine
This is Rietveld 408576698