Issue 2629413003: Fix memory leak in ServiceTestMessageHandler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2629413003: Fix memory leak in ServiceTestMessageHandler. (Closed)

Created:
3 years, 11 months ago by rmacnak

Modified:
3 years, 11 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Fix memory leak in ServiceTestMessageHandler. Guard against potential double-free. Fixes #28342 R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/89986c0b03a10885072a517144f3ef4aa6526359

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -10 lines)			Patch
	M	runtime/tests/vm/vm.status	View		1 chunk	+0 lines, -10 lines	0 comments	Download
	M	runtime/vm/service_test.cc	View		2 chunks	+3 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

rmacnak

3 years, 11 months ago (2017-01-13 23:08:10 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
89986c0b03a10885072a517144f3ef4aa6526359 (presubmit successful).